ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole" <nc...@hortonworks.com>
Subject Re: Review Request 36554: MySQL Connection Pooling Defaults Should Be Correct And Present In ambari.properties
Date Thu, 16 Jul 2015 20:38:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36554/#review91961
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On July 16, 2015, 4:34 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36554/
> -----------------------------------------------------------
> 
> (Updated July 16, 2015, 4:34 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
> 
> 
> Bugs: AMBARI-12438
>     https://issues.apache.org/jira/browse/AMBARI-12438
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The following are properties that are exposed via {{ambari.properties}} and which have
hard coded defaults in the Java code but appear no where in {{ambari.properties}} in a default
installation:
> 
> {noformat}
> server.jdbc.connection-pool=c3p0
> server.jdbc.connection-pool.acquisition-size=5
> server.jdbc.connection-pool.max-age=0
> server.jdbc.connection-pool.max-idle-time=14400
> server.jdbc.connection-pool.max-idle-time-excess=0
> server.jdbc.connection-pool.idle-test-interval=7200
> {noformat}
> 
> We should write these properties into {{ambari.properties}} at install-time when configuring
the database. MySQL will get c3p0 by default while other database providers will get "internal"
(JPA) as their pooling mechanism.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py 25958eb 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 1a56fa6 
>   ambari-server/src/test/python/TestAmbariServer.py db16927 
> 
> Diff: https://reviews.apache.org/r/36554/diff/
> 
> 
> Testing
> -------
> 
> Executed `ambari-server setup` with embedded postgres, external postgres and external
MySQL and verified the correct properties are written to ambari.properties.
> 
> ----------------------------------------------------------------------
> Total run:772
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message