ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitro Lisnichenko" <dlysniche...@hortonworks.com>
Subject Re: Review Request 36542: Optimization proposal: merge all status commands into one to optimize network bandwidth
Date Thu, 16 Jul 2015 11:13:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36542/#review91878
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On July 16, 2015, 9:44 a.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36542/
> -----------------------------------------------------------
> 
> (Updated July 16, 2015, 9:44 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-12431
>     https://issues.apache.org/jira/browse/AMBARI-12431
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> As of now, both in python and at puppet status commands are created per-
> component. All commands for host are created at once in a loop at
> org.apache.ambari.server.agent.HeartbeatMonitor#generateStatusCommands . All
> the difference between status commands is a component name and path to script.
> So we may reduce number and summary size of commands by sending an entire list
> of components in a single status command.  
> I'm attaching a dump of a single heartbeat with status commands.
> 
> This should also include SECURITY_STATUS merging, which will help in terms of
> and similar resolution
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py 6a64f99 
>   ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 4e130f9 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 6f34b62

>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java d245a25

>   ambari-server/src/main/java/org/apache/ambari/server/agent/StatusCommand.java 5dec53c

>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
15d7904 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java
d3fee8b 
> 
> Diff: https://reviews.apache.org/r/36542/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message