ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Onischuk" <aonis...@hortonworks.com>
Subject Review Request 36541: Improve checks for ambari.properties file for missing/needed properties during startup
Date Thu, 16 Jul 2015 09:24:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36541/
-----------------------------------------------------------

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-12430
    https://issues.apache.org/jira/browse/AMBARI-12430


Repository: ambari


Description
-------

While upgrading the cluster, there were many properties that were missing in
Ambari properties file. This is 1.7/2.2 stack -> 2.0/2.2.4 stack -> 2.1/2.3
stack upgrade. There should be some checking to ensure the critical properties
are present and addition of properties that are required but missing.

Without this we're just hoping all the properties are there and otherwise user
gets an error that they cannot make sense of and requires manual intervention
from Ambari team.


Diffs
-----

  ambari-server/src/main/python/ambari_server/serverConfiguration.py cf7ab4b 
  ambari-server/src/main/python/ambari_server_main.py bc561a1 
  ambari-server/src/test/python/TestAmbariServer.py db16927 

Diff: https://reviews.apache.org/r/36541/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message