ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 36374: Add connection pool acquisition retry count and delay overrides
Date Fri, 10 Jul 2015 17:32:00 GMT


> On July 10, 2015, 5:55 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java,
line 256
> > <https://reviews.apache.org/r/36374/diff/1/?file=1004439#file1004439line256>
> >
> >     Is this OK for any underlying DB types?

Agree with Sumit, this needs to be tested on Postgres, Oracle, MySQL, and if possible MsSQL.


- Alejandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36374/#review91270
-----------------------------------------------------------


On July 9, 2015, 11:42 p.m., Nadav Caspi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36374/
> -----------------------------------------------------------
> 
> (Updated July 9, 2015, 11:42 p.m.)
> 
> 
> Review request for Ambari, Mahadev Konar and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-12346
>     https://issues.apache.org/jira/browse/AMBARI-12346
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Adding the ability to configure the connection pool acquisition retry count and retry
delay.
> The current defaults of the library are:
> Retries: 30
> Delay: 1000 milliseconds
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
6c98457 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
ac651ce 
>   ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
70ab3b6 
> 
> Diff: https://reviews.apache.org/r/36374/diff/
> 
> 
> Testing
> -------
> 
> Unit test
> 
> 
> Thanks,
> 
> Nadav Caspi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message