ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Nettleton" <rnettle...@hortonworks.com>
Subject Re: Review Request 36376: BP configuration methods getFullProperties() and getFullAttributes() may modify the underlying configuration in some cases
Date Thu, 09 Jul 2015 22:03:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36376/#review91216
-----------------------------------------------------------

Ship it!


Ship It!

- Robert Nettleton


On July 9, 2015, 9:54 p.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36376/
> -----------------------------------------------------------
> 
> (Updated July 9, 2015, 9:54 p.m.)
> 
> 
> Review request for Ambari and Robert Nettleton.
> 
> 
> Bugs: AMBARI-12366
>     https://issues.apache.org/jira/browse/AMBARI-12366
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In some cases the methods getFullProperties() and getFullAttributes() in the Configuration
class modify the underlying configuration. In one path, a deep copy isn't being properly done
on the configuration maps so the underlying map is being modified. This can cause a host group
configuration to be set on the cluster scoped configuration.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/Configuration.java 91b7736

>   ambari-server/src/test/java/org/apache/ambari/server/topology/ConfigurationTest.java
9bab88f 
> 
> Diff: https://reviews.apache.org/r/36376/diff/
> 
> 
> Testing
> -------
> 
> Functional:
> - Deployed a cluster via blueprint which contained host group scoped config
> Unit:
> - Fixed existing unit tests to catch this scenario
> - Currently running full unit test suite and will update Jira with results prior to merging
> 
> 
> Thanks,
> 
> John Speidel
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message