ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sumit Mohanty" <smoha...@hortonworks.com>
Subject Re: Review Request 36339: Various Configs in webcat-site.xml Are Using Paths With 'current' Rather Than Version
Date Thu, 09 Jul 2015 01:07:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36339/#review91034
-----------------------------------------------------------

Ship it!


Ship It!

- Sumit Mohanty


On July 9, 2015, 12:44 a.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36339/
> -----------------------------------------------------------
> 
> (Updated July 9, 2015, 12:44 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-12344
>     https://issues.apache.org/jira/browse/AMBARI-12344
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> some examples
> 
> ```xml
> <?xml version="1.0" encoding="UTF-8"?>
> <property>
>   <name>templeton.hadoop</name>
>   <value>/usr/hdp/current/hadoop-client/bin/hadoop</value>
> </property>
> <property>
>   <name>templeton.hcat</name>
>   <value>/usr/hdp/current/hive-client/bin/hcat</value>
> </property>
> <property>
>   <name>templeton.hive.extra.files</name>
>   <value>/etc/tez/conf/tez-site.xml,/usr/hdp/current/tez-client,/usr/hdp/current/tez-client/lib</value>
> </property>
> <property>
>   <name>templeton.jar</name>
>   <value>/usr/hdp/current/hive-webhcat/share/webhcat/svr/lib/hive-webhcat-*.jar</value>
> </property>
> <property>
>   <name>templeton.libjars</name>
>   <value>/usr/hdp/current/zookeeper-client/zookeeper.jar,/usr/hdp/current/hive-server2/lib/hive-common.jar</value>
> </property>
> ```
> 
> We should be using paths with version to make sure webhcat is running with the same version
client as its running with.
> 
> There's a simple solution for this: we use the property hdp.version instead of current.
You can see other configs in the same file that depend on hdp.version. hdp.version is tested
with other configuration properties, so if we change these current references to hdp.version,
we should be good.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/webhcat-site.xml
d95be55 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml c5fb156 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/webhcat-site.xml
d9dd169 
> 
> Diff: https://reviews.apache.org/r/36339/diff/
> 
> 
> Testing
> -------
> 
> Upgraded Hive and verified webhcat-site.xml no longer contains references to `current`
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message