ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 36150: RU PreCheck to exclude Slaves
Date Mon, 06 Jul 2015 17:20:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36150/#review90503
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java (line 93)
<https://reviews.apache.org/r/36150/#comment143621>

    Comment should say "equal to or more than 1"


- Alejandro Fernandez


On July 2, 2015, 10:50 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36150/
> -----------------------------------------------------------
> 
> (Updated July 2, 2015, 10:50 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-12268
>     https://issues.apache.org/jira/browse/AMBARI-12268
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> * Modify the service-up-check to make a calculation for slaves whose cardinality is "1+"
- other slaves should be checked, but the "1+" are things like DN, NM, RS, Supervisors.
> * Also added a stack trace to a log we rarely get, but is really annoying.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java 296624d

>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java
ff50bc9 
>   ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesUpCheckTest.java
87cb8a9 
> 
> Diff: https://reviews.apache.org/r/36150/diff/
> 
> 
> Testing
> -------
> 
> Tests run: 3106, Failures: 0, Errors: 0, Skipped: 28
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 29:22 min
> [INFO] Finished at: 2015-07-02T18:21:33-04:00
> [INFO] Final Memory: 32M/1186M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message