ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Review Request 36142: Some Execution Commands Send Stale Configs During Upgrade Causing Invalid Alerts
Date Thu, 02 Jul 2015 19:44:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36142/
-----------------------------------------------------------

Review request for Ambari, Nate Cole and Srimanth Gunturi.


Bugs: AMBARI-12264
    https://issues.apache.org/jira/browse/AMBARI-12264


Repository: ambari


Description
-------

During an upgrade, the alert check for hive transitions to the new port, {{10010}} and begins
returning valid checks once the upgraded hive server starts up on the new port. 

However, after the upgrade is finalized, it is observed that the configurations sent down
to the agents contains the old hive thrift port, {{10000}} from before the upgrade ran. 

Restarting the agents corrects the problems since the configurations in ambari server are
still correct.

The problem is that some commands, namely, {{ACTIONEXECUTE}} must also set
- {code}
    "forceRefreshConfigTagsBeforeExecution": [
        "*"
    ],
{code}

on the {{ExecutionCommands}} being sent down.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
1e1001c 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
55cf453 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java
35b92ff 
  ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/upgrade_test.xml f321d4c 

Diff: https://reviews.apache.org/r/36142/diff/


Testing
-------

mvn clean test

Upgraded Hive with a finalize action and verified that the ports no longer change.


Thanks,

Jonathan Hurley


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message