ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 36095: Custom actions do not allow max time out higher than 10 minutes
Date Wed, 01 Jul 2015 18:13:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36095/#review90084
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On July 1, 2015, 4:56 p.m., Sumit Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36095/
> -----------------------------------------------------------
> 
> (Updated July 1, 2015, 4:56 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sid Wagle.
> 
> 
> Bugs: AMBARI-12233
>     https://issues.apache.org/jira/browse/AMBARI-12233
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Custom actions do not allow max time out higher than 10 minutes. The code was hard-coding
an upper limit as run-away custom actions could hold othe operations. However, its better
to rely on the max limit config from ambari-server properties.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
1e1001c 
>   ambari-server/src/main/java/org/apache/ambari/server/customactions/ActionDefinitionManager.java
e058ce7 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
5ee2016 
> 
> Diff: https://reviews.apache.org/r/36095/diff/
> 
> 
> Testing
> -------
> 
> Ran unit tests and manually tested with different timeout values.
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message