Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 421CD18897 for ; Thu, 25 Jun 2015 20:37:28 +0000 (UTC) Received: (qmail 36323 invoked by uid 500); 25 Jun 2015 20:37:28 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 36289 invoked by uid 500); 25 Jun 2015 20:37:28 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 36273 invoked by uid 99); 25 Jun 2015 20:37:27 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Jun 2015 20:37:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A07B7AADB0; Thu, 25 Jun 2015 20:37:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5587283491405327276==" MIME-Version: 1.0 Subject: Re: Review Request 35866: Kerberos configs aren't restored when moving back from Review to the Configure Identities step From: "Yusaku Sako" To: "Yusaku Sako" , "Jaimin Jetly" Cc: "Richard Zang" , "Ambari" Date: Thu, 25 Jun 2015 20:37:26 -0000 Message-ID: <20150625203726.3113.4154@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Yusaku Sako" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/35866/ X-Sender: "Yusaku Sako" References: <20150625200632.3114.94560@reviews.apache.org> In-Reply-To: <20150625200632.3114.94560@reviews.apache.org> Reply-To: "Yusaku Sako" X-ReviewRequest-Repository: ambari --===============5587283491405327276== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35866/#review89419 ----------------------------------------------------------- Also, let's not store kerberos admin credentials in browser local db storage. It's a security risk. - Yusaku Sako On June 25, 2015, 8:06 p.m., Richard Zang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35866/ > ----------------------------------------------------------- > > (Updated June 25, 2015, 8:06 p.m.) > > > Review request for Ambari, Jaimin Jetly and Yusaku Sako. > > > Bugs: AMBARI-12141 > https://issues.apache.org/jira/browse/AMBARI-12141 > > > Repository: ambari > > > Description > ------- > > Kerberos configs aren't restored when moving back from Review to the Configure Identities step > > > Diffs > ----- > > ambari-web/app/controllers/main/admin/kerberos/step4_controller.js f5f232f > ambari-web/app/routes/add_service_routes.js 2df6c99 > > Diff: https://reviews.apache.org/r/35866/diff/ > > > Testing > ------- > > Unit test passed. > 6419 tests complete (9 seconds) > 86 tests pending > > > Thanks, > > Richard Zang > > --===============5587283491405327276==--