Return-Path: 
 <dev-return-77801-apmail-ambari-dev-archive=ambari.apache.org@ambari.apache.org>
X-Original-To: apmail-ambari-dev-archive@www.apache.org
Delivered-To: apmail-ambari-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 608FE18599
	for <apmail-ambari-dev-archive@www.apache.org>;
 Sat, 20 Jun 2015 19:49:29 +0000 (UTC)
Received: (qmail 59636 invoked by uid 500); 20 Jun 2015 19:49:29 -0000
Delivered-To: apmail-ambari-dev-archive@ambari.apache.org
Received: (qmail 59609 invoked by uid 500); 20 Jun 2015 19:49:29 -0000
Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@ambari.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@ambari.apache.org>
List-Post: <mailto:dev@ambari.apache.org>
List-Id: <dev.ambari.apache.org>
Reply-To: dev@ambari.apache.org
Delivered-To: mailing list dev@ambari.apache.org
Received: (qmail 59592 invoked by uid 99); 20 Jun 2015 19:49:28 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 20 Jun 2015 19:49:28 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 874583E7FD;
	Sat, 20 Jun 2015 19:49:28 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============5057800400733124546=="
MIME-Version: 1.0
Subject: Review Request 35700: Views : Error deploying all non-system views
From: "Tom Beerbower" <tbeerbower@hortonworks.com>
To: "Mahadev Konar" <mahadev@apache.org>
Cc: "Ambari" <dev@ambari.apache.org>,
 "Tom Beerbower" <tbeerbower@hortonworks.com>
Date: Sat, 20 Jun 2015 19:49:28 -0000
Message-ID: <20150620194928.1458.46316@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org/
Auto-Submitted: auto-generated
Sender: "Tom Beerbower" <noreply@reviews.apache.org>
X-ReviewGroup: Ambari
X-Auto-Response-Suppress: DR, RN, OOF, AutoReply
X-ReviewRequest-URL: https://reviews.apache.org/r/35700/
X-Sender: "Tom Beerbower" <noreply@reviews.apache.org>
Reply-To: "Tom Beerbower" <tbeerbower@hortonworks.com>
X-ReviewRequest-Repository: ambari

--===============5057800400733124546==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35700/
-----------------------------------------------------------

Review request for Ambari and Mahadev Konar.


Bugs: AMBARI-12048
    https://issues.apache.org/jira/browse/AMBARI-12048


Repository: ambari


Description
-------

View registry attempting to read the descriptor from the extracted view archive before doing the extraction.

Regression introduced by AMBARI-11991.

    19 Jun 2015 19:39:55,002  INFO [pool-4-thread-5] ViewRegistry:1535 - Reading view archive /var/lib/ambari-server/resources/views/pig-2.1.0.1168.jar.
    19 Jun 2015 19:39:55,021 ERROR [pool-4-thread-5] ViewRegistry:1567 - Caught exception loading view PIG{1.0.0}
    java.io.FileNotFoundException: /var/lib/ambari-server/resources/views/work/PIG{1.0.0}/WEB-INF/classes/view.xml (No such file or directory)
        at java.io.FileInputStream.open0(Native Method)
        at java.io.FileInputStream.open(FileInputStream.java:195)
        at java.io.FileInputStream.<init>(FileInputStream.java:138)
        at org.apache.ambari.server.view.ViewArchiveUtility.getViewConfigFromExtractedArchive(ViewArchiveUtility.java:116)
        at org.apache.ambari.server.view.ViewRegistry.readViewArchive(ViewRegistry.java:1539)
        at org.apache.ambari.server.view.ViewRegistry.access$000(ViewRegistry.java:119)
        at org.apache.ambari.server.view.ViewRegistry$5.run(ViewRegistry.java:1492)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at java.lang.Thread.run(Thread.java:745)


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java c7630ed 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewArchiveUtility.java 0472756 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 28016ea 
  ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java 09df011 

Diff: https://reviews.apache.org/r/35700/diff/


Testing
-------

Manual tested to verify that all views are deployed.

mvn clean test

results pending ...


Thanks,

Tom Beerbower


--===============5057800400733124546==--