Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8A3D9185E7 for ; Wed, 17 Jun 2015 17:59:28 +0000 (UTC) Received: (qmail 65343 invoked by uid 500); 17 Jun 2015 17:59:28 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 65312 invoked by uid 500); 17 Jun 2015 17:59:28 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 65297 invoked by uid 99); 17 Jun 2015 17:59:28 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Jun 2015 17:59:28 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DFE971DFEC1; Wed, 17 Jun 2015 17:59:27 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5374712054143814357==" MIME-Version: 1.0 Subject: Re: Review Request 35130: Handle if non-default value is used for hbase.tmp.dir From: "Sumit Mohanty" To: "Sumit Mohanty" , "Vitalyi Brodetskyi" Cc: "Andrew Onischuk" , "Ambari" Date: Wed, 17 Jun 2015 17:59:27 -0000 Message-ID: <20150617175927.1512.82568@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Sumit Mohanty" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/35130/ X-Sender: "Sumit Mohanty" References: <20150617161819.1512.29390@reviews.apache.org> In-Reply-To: <20150617161819.1512.29390@reviews.apache.org> Reply-To: "Sumit Mohanty" X-ReviewRequest-Repository: ambari --===============5374712054143814357== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35130/#review88251 ----------------------------------------------------------- Ship it! Ship It! - Sumit Mohanty On June 17, 2015, 4:18 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35130/ > ----------------------------------------------------------- > > (Updated June 17, 2015, 4:18 p.m.) > > > Review request for Ambari, Sumit Mohanty and Vitalyi Brodetskyi. > > > Bugs: AMBARI-11721 > https://issues.apache.org/jira/browse/AMBARI-11721 > > > Repository: ambari > > > Description > ------- > > tyu, with the changes due to BUG - 37006, now there is no logic in the HBase > stack definition to process the value of `hbase.tmp.dir`. > > If user changes the value from the default (it is possible to change it using > UI or blueprint) then we will run into the same problem when UI was using the > value `/grid/0/...`. HBase master will fail to start if the root folder does > not have proper permissions. > > I think the fix needed here is to have HBase scripts parse the folder path and > if it does not start with "/tmp" then it needs to process it and > create/chmod/chown folders as needed. > > FYI, ddas/sgupta. > > > Diffs > ----- > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 1bfa7e4 > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py e8585cd > ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py afe3de6 > ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py da0d624 > ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 47e8ef3 > > Diff: https://reviews.apache.org/r/35130/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > > --===============5374712054143814357==--