Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============8269339673508141990=="
MIME-Version: 1.0
Subject: Re: Review Request 35351: Tell Ambari the value of
 topology.max.replication.wait.time.sec for Storm HA. Tweak
 topology.min.replication.count for HA case
From: "Dmitro Lisnichenko" <dlysnichenko@hortonworks.com>
To: "Parth Brahmbhatt" <brahmbhatt.parth@gmail.com>,
 "Vitalyi Brodetskyi" <vbrodetskyi@hortonworks.com>,
 "Sriharsha Chintalapani" <harsha@hortonworks.com>,
 "Jonathan Hurley" <jhurley@hortonworks.com>
Cc: "Dmitro Lisnichenko" <dlysnichenko@hortonworks.com>,
 "Ambari" <dev@ambari.apache.org>
Date: Fri, 12 Jun 2015 08:44:09 -0000
Message-ID: <20150612084409.1448.76419@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Dmitro Lisnichenko" <noreply@reviews.apache.org>
References: <20150611164432.1530.58180@reviews.apache.org>
In-Reply-To: <20150611164432.1530.58180@reviews.apache.org>
Reply-To: "Dmitro Lisnichenko" <dlysnichenko@hortonworks.com>

--===============8269339673508141990==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On June 11, 2015, 4:44 p.m., Parth Brahmbhatt wrote:
> > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py, line 102
> > <https://reviews.apache.org/r/35351/diff/1/?file=982687#file982687line102>
> >
> >     I want to clarify that this value should be 
> >     Math.floor(n/2) + 1. to give concrete examples:
> >     
> >     if n = 1, the value should be 1.
> >     if n = 2, the value should be 2.
> >     if n = 3, the value should still be 3.
> >     if n = 4, the value should be 3.
> >     if n = 5, the value should be 3.
> >     
> >     I am no java script expert but i think without the floor n/2 + 1 will produce a float i.e. for n = 3 the result will be 2.5 which will brake storm. we need to ensure this property is an integer.

That is a python script, and numbers are integer. Mentioned code does exactly what is requested


- Dmitro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35351/#review87575
-----------------------------------------------------------


On June 11, 2015, 12:15 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35351/
> -----------------------------------------------------------
> 
> (Updated June 11, 2015, 12:15 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Parth Brahmbhatt, Sriharsha Chintalapani, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-11435
>     https://issues.apache.org/jira/browse/AMBARI-11435
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Parth Brahmbhatt mentioned that in case of HA topology.min.replication.count should be set to > 1. Ideally it should be floor(n/2 +1).
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py 68f2d0e 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_windows.py 4853762 
> 
> Diff: https://reviews.apache.org/r/35351/diff/
> 
> 
> Testing
> -------
> 
> ----------------------------------------------------------------------
> Ran 266 tests in 8.558s
> 
> OK
> ----------------------------------------------------------------------
> Total run:785
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


--===============8269339673508141990==--