Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============6405962750327384238=="
MIME-Version: 1.0
Subject: Review Request 35352: AMBARI-11810: Rolling upgrade does not run
 pre-upgrade checks against non-HDP stack
From: "Di Li" <dili@ca.ibm.com>
To: "Alejandro Fernandez" <afernandez@hortonworks.com>
Cc: "Di Li" <dili@ca.ibm.com>, "Ambari" <dev@ambari.apache.org>
Date: Thu, 11 Jun 2015 12:17:43 -0000
Message-ID: <20150611121743.1530.26520@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Di Li" <noreply@reviews.apache.org>
Reply-To: "Di Li" <dili@ca.ibm.com>

--===============6405962750327384238==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35352/
-----------------------------------------------------------

Review request for Ambari and Alejandro Fernandez.


Bugs: AMBARI-11810
    https://issues.apache.org/jira/browse/AMBARI-11810


Repository: ambari


Description
-------

All the rolling upgrade pre-checks may still need to run against a non-HDP stack. Use this JIRA to make the check runnable based on properties (rollingupgrade.stack, rollingupgrade.version) set in the /etc/ambari-server/conf/ambari.properties. Still default to HDP and 2.2.4.2 if the properties do not exist.

org.apache.ambari.server.checks.AbstractCheckDescriptor compares stack against hardcoded StackInfo "HDP-2.2". the stack name and version info can be externalized into the /etc/ambari-server/conf/ambar.properties in order to support non-HDP stacks.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java 8cabf29 
  ambari-server/src/test/java/org/apache/ambari/server/checks/AbstractCheckDescriptorTest.java 4834cee 

Diff: https://reviews.apache.org/r/35352/diff/


Testing
-------

Added new unit tests

Manually tested the fix by kicking off the rolling upgrade
1. With no properties in /etc/ambari-server/conf/ambari.properties, Java code used the default HDP-2.2 StackId information and performed the upgrade pre-checks.
2. With wrong property values in ambari.properties, Java code threw err about the StackId did not match
3. With correct property values in ambari.properties, Java code used the stack id and performed the upgrade pre-checks.


Thanks,

Di Li


--===============6405962750327384238==--