Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9DA8618B0B for ; Tue, 9 Jun 2015 18:47:21 +0000 (UTC) Received: (qmail 33482 invoked by uid 500); 9 Jun 2015 18:47:21 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 33445 invoked by uid 500); 9 Jun 2015 18:47:21 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 33431 invoked by uid 99); 9 Jun 2015 18:47:21 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Jun 2015 18:47:21 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0ED471DF932; Tue, 9 Jun 2015 18:47:20 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3603924303300211432==" MIME-Version: 1.0 Subject: Re: Review Request 35135: AMBARI-11700: YarnTimelineServerStatePreservingCheck does not run when rolling upgrade a non-HDP stack From: "Alejandro Fernandez" To: "Alejandro Fernandez" Cc: "Di Li" , "Ambari" Date: Tue, 09 Jun 2015 18:47:20 -0000 Message-ID: <20150609184720.27735.68061@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Alejandro Fernandez" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/35135/ X-Sender: "Alejandro Fernandez" References: <20150605143625.7996.47202@reviews.apache.org> In-Reply-To: <20150605143625.7996.47202@reviews.apache.org> Reply-To: "Alejandro Fernandez" X-ReviewRequest-Repository: ambari --===============3603924303300211432== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35135/#review87259 ----------------------------------------------------------- Ship it! Ship It! - Alejandro Fernandez On June 5, 2015, 2:36 p.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35135/ > ----------------------------------------------------------- > > (Updated June 5, 2015, 2:36 p.m.) > > > Review request for Ambari and Alejandro Fernandez. > > > Bugs: AMBARI-11700 > https://issues.apache.org/jira/browse/AMBARI-11700 > > > Repository: ambari > > > Description > ------- > > The goal of this JIRA is to support running the YarnTimelineServerStatePreservingCheck against non-HDP stacks, by externalizing the stack name and verison. > > The YarnTimelineServerStatePreservingCheck class skips running the check when the rolling upgrade is for non-HDP stack, due to the comparison against hardcoded stack name "HDP" and version value "2.2.4.2". > > The check may still need to run against a non-HDP stack. Use this JIRA to make the check runnable based on properties (rollingupgrade.stack, rollingupgrade.version) set in the /etc/ambari-server/conf/ambari.properties. Still default to HDP and 2.2.4.2 if the properties do not exist. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheck.java ef7cbff > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 4536b3c > ambari-server/src/test/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheckTest.java 4f2da3b > > Diff: https://reviews.apache.org/r/35135/diff/ > > > Testing > ------- > > updated unit test. manual test by kicking off the rolling upgrade > > > Thanks, > > Di Li > > --===============3603924303300211432==--