Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8DC5A18230 for ; Tue, 9 Jun 2015 15:24:37 +0000 (UTC) Received: (qmail 95188 invoked by uid 500); 9 Jun 2015 15:24:37 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 95159 invoked by uid 500); 9 Jun 2015 15:24:37 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 95145 invoked by uid 99); 9 Jun 2015 15:24:37 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Jun 2015 15:24:37 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B31651DF932; Tue, 9 Jun 2015 15:24:35 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6028013455379782735==" MIME-Version: 1.0 Subject: Re: Review Request 35251: Oozie crashes after start on blueprint install From: "Andrew Onischuk" To: "Vitalyi Brodetskyi" Cc: "Andrew Onischuk" , "Robert Nettleton" , "Ambari" Date: Tue, 09 Jun 2015 15:24:35 -0000 Message-ID: <20150609152435.27735.59792@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Andrew Onischuk" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/35251/ X-Sender: "Andrew Onischuk" References: <20150609150925.27735.15173@reviews.apache.org> In-Reply-To: <20150609150925.27735.15173@reviews.apache.org> Reply-To: "Andrew Onischuk" X-ReviewRequest-Repository: ambari --===============6028013455379782735== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On June 9, 2015, 3:09 p.m., Robert Nettleton wrote: > > ambari-server/src/main/resources/common-services/OOZIE/5.0.0.2.3/configuration/oozie-env.xml, line 24 > > > > > > Why is this being removed in this patch? This looks like an un-related change. > > Andrew Onischuk wrote: > This is unrelated change, that changes are duplicated beyond having properties inhertance. This is just a refactoring I saw on my way doing the changes. > > Robert Nettleton wrote: > Thanks for the info. I would recommend implementing this as a separate patch, since it is not related to the oozie_heapsize fix. Sorry just committed the change :( - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35251/#review87188 ----------------------------------------------------------- On June 9, 2015, 3:21 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35251/ > ----------------------------------------------------------- > > (Updated June 9, 2015, 3:21 p.m.) > > > Review request for Ambari and Vitalyi Brodetskyi. > > > Bugs: AMBARI-11811 > https://issues.apache.org/jira/browse/AMBARI-11811 > > > Repository: ambari > > > Description > ------- > > Oozie is thinking that heapsize is in kb and failing with too low > heapsize. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java ca7b2b1 > ambari-server/src/main/resources/common-services/OOZIE/5.0.0.2.3/configuration/oozie-env.xml fe80bf5 > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/metainfo.xml ca82d46 > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java b049fd3 > > Diff: https://reviews.apache.org/r/35251/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > > --===============6028013455379782735==--