Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BBB35177DA for ; Tue, 9 Jun 2015 11:17:07 +0000 (UTC) Received: (qmail 36016 invoked by uid 500); 9 Jun 2015 11:17:07 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 35979 invoked by uid 500); 9 Jun 2015 11:17:07 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 35964 invoked by uid 99); 9 Jun 2015 11:17:07 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Jun 2015 11:17:07 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 42A071DF931; Tue, 9 Jun 2015 11:17:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6829489371808900419==" MIME-Version: 1.0 Subject: Re: Review Request 35073: Kerberos: Force principal names to resolve to lowercase lower usernames in auth-to-local default rules From: "Robert Levas" To: "Robert Levas" , "Vitalyi Brodetskyi" , "Tom Beerbower" Cc: "Emil Anca" , "Ambari" Date: Tue, 09 Jun 2015 11:17:06 -0000 Message-ID: <20150609111706.27735.94538@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Robert Levas" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/35073/ X-Sender: "Robert Levas" References: <20150609095525.27736.1206@reviews.apache.org> In-Reply-To: <20150609095525.27736.1206@reviews.apache.org> Reply-To: "Robert Levas" X-ReviewRequest-Repository: ambari --===============6829489371808900419== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35073/#review87159 ----------------------------------------------------------- Ship it! ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java A NPE will be thrown if `kerberos-env/case_insensitive_rules` is null or not present in the map. - Robert Levas On June 9, 2015, 5:55 a.m., Emil Anca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35073/ > ----------------------------------------------------------- > > (Updated June 9, 2015, 5:55 a.m.) > > > Review request for Ambari, Robert Levas, Tom Beerbower, and Vitalyi Brodetskyi. > > > Bugs: AMBARI-11687 > https://issues.apache.org/jira/browse/AMBARI-11687 > > > Repository: ambari > > > Description > ------- > > Force principals names to resolve to lowercase local usernames in auth-to-local rules. This will help when the KDC is an MIT KDC or an Active Directory and user accounts have uppercase letters that need to be converted to lowercase letters. For example: {{USER1234@REALM}} should resolve to {{user1234}}. > > *Solution* > # Provide a kerberos-env configuration to optionally create case-insensitive rules > # If creating case-insensitive rules, _generic_ auth-to-local rules should contain the {{L}} option, as in: > > ~~~ > RULE:[1:$1@$0](.*@REALM)s/@.*///L > ~~~ > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/controller/AuthToLocalBuilder.java 89d0b55 > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java 8a5d4fd > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml 6d720a0 > ambari-server/src/test/java/org/apache/ambari/server/controller/AuthToLocalBuilderTest.java d1a2bd1 > ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java f8ba840 > ambari-web/app/data/HDP2/site_properties.js 484ad38 > > Diff: https://reviews.apache.org/r/35073/diff/ > > > Testing > ------- > > * mvn clean test -pl AuthToLocalBuilderTest KerberosHelperImpl locally > * Jenking tests in progress > * Kerbernized/dekerbenized prop with / without prop while monitoring core-site auth to local rules > * Added service on kerberized cluster > * Ran > > [root@c6401 ~]# hadoop org.apache.hadoop.security.HadoopKerberosName EAnca@EXAMPLE.COM > Name: EAnca@EXAMPLE.COM to eanca > > to test the mapping of the new generic Rule. > > > Thanks, > > Emil Anca > > --===============6829489371808900419==--