Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============4414627833134087892=="
MIME-Version: 1.0
Subject: Re: Review Request 35185: Oozie Web Alert Has Wrong http Property In
 Alert Definition
From: "Nate Cole" <ncole@hortonworks.com>
To: "Alejandro Fernandez" <afernandez@hortonworks.com>,
 "Nate Cole" <ncole@hortonworks.com>
Cc: "Ambari" <dev@ambari.apache.org>,
 "Jonathan Hurley" <jhurley@hortonworks.com>
Date: Sun, 07 Jun 2015 13:09:22 -0000
Message-ID: <20150607130922.27735.8856@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Nate Cole" <noreply@reviews.apache.org>
References: <20150607023102.7997.31111@reviews.apache.org>
In-Reply-To: <20150607023102.7997.31111@reviews.apache.org>
Reply-To: "Nate Cole" <ncole@hortonworks.com>

--===============4414627833134087892==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35185/#review86963
-----------------------------------------------------------

Ship it!


ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/alerts.json
<https://reviews.apache.org/r/35185/#comment139181>

    I realize not a part of this jira (and won't hold it up), but should user.name=oozie be user.name=\{\{oozie-env/oozie_user\}\} ?


- Nate Cole


On June 6, 2015, 10:31 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35185/
> -----------------------------------------------------------
> 
> (Updated June 6, 2015, 10:31 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
> 
> 
> Bugs: AMBARI-11749
>     https://issues.apache.org/jira/browse/AMBARI-11749
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Deployed a clean HDP 2.2 cluster and noticed a 404 NOT FOUND alert for Oozie. The alert definition has the following:
> 
> {code}
> "http": "{{oozie-site/oozie.base.url}}/oozie/?user.name=oozie",
> {code}
> 
> However, {{oozie/site/oozie.base.url}} is {{http://server/oozie}} which makes the alert look for {{http://server/oozie/oozie?usern.name=oozie}} instead of {{http://server/oozie?user.name=oozie}}
> 
> Either the alert definitions (in both 4.* and 5.* OOZIE folders) needs to change or the base url property needs to change.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java c337dec 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java 76cd0fc 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/alerts.json a14f782 
>   ambari-server/src/main/resources/common-services/OOZIE/5.0.0.2.3/alerts.json d75d1b2 
>   ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/OOZIE/alerts.json e57a4f8 
> 
> Diff: https://reviews.apache.org/r/35185/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> Verified new oozie alert definition does not throw a 404
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


--===============4414627833134087892==--