Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 24E1117A7B for ; Wed, 3 Jun 2015 23:59:53 +0000 (UTC) Received: (qmail 23486 invoked by uid 500); 3 Jun 2015 23:59:53 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 23450 invoked by uid 500); 3 Jun 2015 23:59:53 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 23436 invoked by uid 99); 3 Jun 2015 23:59:52 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jun 2015 23:59:52 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4C3501DF378; Wed, 3 Jun 2015 23:59:52 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0597367599535079915==" MIME-Version: 1.0 Subject: Re: Review Request 35040: [WinTP2] ambari-server setup --jdbc-driver displays bogus error From: "Florian Barca" To: "Jayush Luniya" , "Artem Baranchuk" Cc: "Florian Barca" , "Ambari" Date: Wed, 03 Jun 2015 23:59:52 -0000 Message-ID: <20150603235952.7997.24600@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Florian Barca" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/35040/ X-Sender: "Florian Barca" References: <20150603235736.7996.43816@reviews.apache.org> In-Reply-To: <20150603235736.7996.43816@reviews.apache.org> Reply-To: "Florian Barca" X-ReviewRequest-Repository: ambari --===============0597367599535079915== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35040/#review86520 ----------------------------------------------------------- ambari-server/src/main/python/ambari-server.py Without this, the execution wouldn't hit proceedJDBCProperties() - Florian Barca On June 3, 2015, 11:57 p.m., Florian Barca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35040/ > ----------------------------------------------------------- > > (Updated June 3, 2015, 11:57 p.m.) > > > Review request for Ambari, Artem Baranchuk and Jayush Luniya. > > > Bugs: AMBARI-11673 > https://issues.apache.org/jira/browse/AMBARI-11673 > > > Repository: ambari > > > Description > ------- > > +Fixed arguments with spaces in Powershell > +Fixed properties files saving - now all the properties are ordered by key > +Fixed --jdbc-driver argument processing in Windows > > > Diffs > ----- > > ambari-agent/conf/windows/ambari-agent.ps1 69585232bd2dd06c90be73abee8071d86f10277b > ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/properties.py 8e00762d8158d4351544d0a1a88350bdc722332f > ambari-server/src/main/python/ambari-server.py 19b7138379d3e5afdf9a8ae79ba244e26a1d941d > ambari-server/src/main/python/ambari_server/properties.py 37d23c76e7a8a5d2c3eaaf92e450ecb78173e330 > ambari-server/src/main/python/ambari_server/serverConfiguration.py b12228ac773a95f990258a71f1d9a3b21ddc9fb0 > ambari-server/src/main/python/ambari_server/serverSetup.py ede1cf3592df914ad7324007c2db4a5a1f3d9297 > ambari-server/src/main/windows/ambari-server.ps1 690b1a9515569a4652632e91ee278c3a139449ce > ambari-server/src/test/python/TestAmbariServer.py 38a436751184edd82ab3136f14b6b7c197db1fdb > > Diff: https://reviews.apache.org/r/35040/diff/ > > > Testing > ------- > > mvn clean test in Linux > local VM cluster deployment -> ambari-server setup "--jdbc-driver=C:\Program Files\sqljdbc_4.0\enu\" -> appropriate error message displayed > > > Thanks, > > Florian Barca > > --===============0597367599535079915==--