ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Re: Review Request 35940: LDAP sync needs to distinguish group vs user membership
Date Fri, 26 Jun 2015 21:10:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35940/#review89561
-----------------------------------------------------------

Ship it!


Ship It!

- Jonathan Hurley


On June 26, 2015, 3:31 p.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35940/
> -----------------------------------------------------------
> 
> (Updated June 26, 2015, 3:31 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Robert Levas.
> 
> 
> Bugs: AMBARI-12176
>     https://issues.apache.org/jira/browse/AMBARI-12176
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> LDAP sync is pulling in sub groups as users of a parent group. The sync code needs to
distinguish group members from user members.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulator.java
ada4171 
>   ambari-server/src/test/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulatorTest.java
4968730 
> 
> Diff: https://reviews.apache.org/r/35940/diff/
> 
> 
> Testing
> -------
> 
> Manually verified that sub groups are no longer imported as users.
> 
> mvn clean test
> 
> All tests pass ...
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 45:27 min
> [INFO] Finished at: 2015-06-26T13:02:34-04:00
> [INFO] Final Memory: 56M/1585M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message