ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole" <nc...@hortonworks.com>
Subject Re: Review Request 35921: Perf Cluster: Repo Version install stuck in INSTALLING state
Date Fri, 26 Jun 2015 15:39:33 GMT


> On June 26, 2015, 10:40 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py, lines
126-130
> > <https://reviews.apache.org/r/35921/diff/1/?file=993002#file993002line126>
> >
> >     Instead of having a separate variable here which is either `None` or is equal
to `self.repository_version`, you can just have a boolean that defines whether the `self.repository_version`
includes the build number. It would simply this logic a bit and make it clearer.

We can't - people have started making the UI do this:  2.3.0.0-1 so that they can have multiple
2.3's installed at the same time.  There's nothing stopping them from 2.3.0.0-1111 or 2.3.0.0-2222
either.  I think we have to always figure out the correct version and NEVER rely on what is
passed.


- Nate


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35921/#review89499
-----------------------------------------------------------


On June 26, 2015, 7:02 a.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35921/
> -----------------------------------------------------------
> 
> (Updated June 26, 2015, 7:02 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-12161
>     https://issues.apache.org/jira/browse/AMBARI-12161
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Steps to reproduce:
> Register Repo Version
> Start Install Version
> Wait till the request will be completed
> Actual Result:
> Request successfully completed, but Stack Version of host still has INSTALLING status
and so entire stack version has status INSTALLING
> Looks like it is an issue with how repo version is added. I always include build number
into repo version name, and guys seem to skip it. Both workflows are correct, but in latter
case there is a corner case on hosts without versionable components (and /usr/hdp dir)
> 
> This is the best workflow we may follow.
> It's impossible to determine build version when server does not provide it and host does
not contain versionable components.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 0681afe

> 
> Diff: https://reviews.apache.org/r/35921/diff/
> 
> 
> Testing
> -------
> 
> Checked workflow on normal hosts (with versionable components) and without versionable
components few times. In latter case, first package install attempt fails, and second package
install attempt is successful, as desired.
> 
> -----------------------------------------------------------------------
> Ran 266 tests in 6.311s
> 
> OK
> ----------------------------------------------------------------------
> Total run:795
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message