ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitro Lisnichenko" <dlysniche...@hortonworks.com>
Subject Re: Review Request 35781: Remove/review other occurrences of Execute (format("rm -f {pid_file}")) for non-root agent
Date Tue, 23 Jun 2015 09:05:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35781/#review88943
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On June 23, 2015, 8:56 a.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35781/
> -----------------------------------------------------------
> 
> (Updated June 23, 2015, 8:56 a.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-12086
>     https://issues.apache.org/jira/browse/AMBARI-12086
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Based on the issue reported by AMBARI-12043, there are few more occurrences of
> 
>     
>     
>     Execute (format("rm -f {pid_file}"))
> 
> that may also run into same issue.
> 
> ambari-server/src/main/resources/common-
> services/AMBARI_METRICS/0.1.0/package/scripts/hbase_service.py  
> ambari-server/src/main/resources/common-
> services/HBASE/0.96.0.2.0/package/scripts/phoenix_service.py
> 
> Also, is the preferred fix pattern
> 
>     
>     
>     
>     Execute(format("rm -f {pid_file}"),
>             user=params.accumulo_user)
>     
> 
> OR
> 
>     
>     
>     
>     File(pid_file,
>                action = "delete",
>           )
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_service.py
180755f 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_service.py
8aa1994 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py 436660e

> 
> Diff: https://reviews.apache.org/r/35781/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message