ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yusaku Sako" <yus...@hortonworks.com>
Subject Re: Review Request 35704: Yarn config tab not loading when localhost is present in hive JDBC url
Date Sat, 20 Jun 2015 22:37:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35704/#review88672
-----------------------------------------------------------

Ship it!


Ship It!

- Yusaku Sako


On June 20, 2015, 10:28 p.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35704/
> -----------------------------------------------------------
> 
> (Updated June 20, 2015, 10:28 p.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
> 
> 
> Bugs: AMBARI-12051
>     https://issues.apache.org/jira/browse/AMBARI-12051
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> While parsing out hive_jdbc_url, localhost is parsed out which is interpreted as invalid
hostname and a fallback config property is looked for hive_ambari_host(hive server hostname)
which is not present while loading yarn config tab.
> 
> Solution:
> Localhost should be treated as a valid hostname
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/utils/validator.js 00b02d9 
>   ambari-web/test/utils/validator_test.js 1ad5989 
> 
> Diff: https://reviews.apache.org/r/35704/diff/
> 
> 
> Testing
> -------
> 
> Tested on a live cluster
> Added unit test 
> Verified that all unit tests passes for ambari-web:
> 
>   6648 tests complete (11 seconds)
>   86 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message