ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower" <tbeerbo...@hortonworks.com>
Subject Review Request 35617: Provide meaningful error message for URLStreamProvider
Date Thu, 18 Jun 2015 20:01:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35617/
-----------------------------------------------------------

Review request for Ambari, Nate Cole and Robert Levas.


Bugs: AMBARI-12006
    https://issues.apache.org/jira/browse/AMBARI-12006


Repository: ambari


Description
-------

Seeing this exception ...

    Caused by: java.lang.NullPointerException
	    at java.io.File.<init>(File.java:277)
	    at org.apache.ambari.server.controller.internal.URLStreamProvider.getSSLConnection(URLStreamProvider.java:280)

The NPE is due to the fact that ssl.trustStore.path is not set in ambari.properites.   It
is expected that the ssl.truststore configuration properties be set for https requests through
the URLStreamProvider.


The Ambari code should be cleaned up to verify not null and log a meaningful error (instead
of NPE).


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/URLStreamProvider.java
1a8b085 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
4e18c7f 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/URLStreamProviderTest.java
7268ff2 

Diff: https://reviews.apache.org/r/35617/diff/


Testing
-------

new unit test added 

mvn clean test

all pass

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 46:04 min
[INFO] Finished at: 2015-06-18T15:07:52-04:00
[INFO] Final Memory: 54M/1297M
[INFO] ------------------------------------------------------------------------


Thanks,

Tom Beerbower


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message