ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sumit Mohanty" <smoha...@hortonworks.com>
Subject Re: Review Request 35130: Handle if non-default value is used for hbase.tmp.dir
Date Wed, 17 Jun 2015 17:59:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35130/#review88251
-----------------------------------------------------------

Ship it!


Ship It!

- Sumit Mohanty


On June 17, 2015, 4:18 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35130/
> -----------------------------------------------------------
> 
> (Updated June 17, 2015, 4:18 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-11721
>     https://issues.apache.org/jira/browse/AMBARI-11721
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> tyu, with the changes due to BUG - 37006, now there is no logic in the HBase
> stack definition to process the value of `hbase.tmp.dir`.
> 
> If user changes the value from the default (it is possible to change it using
> UI or blueprint) then we will run into the same problem when UI was using the
> value `/grid/0/...`. HBase master will fail to start if the root folder does
> not have proper permissions.
> 
> I think the fix needed here is to have HBase scripts parse the folder path and
> if it does not start with "/tmp" then it needs to process it and
> create/chmod/chown folders as needed.
> 
> FYI, ddas/sgupta.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
1bfa7e4 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
e8585cd 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py afe3de6 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py da0d624 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 47e8ef3

> 
> Diff: https://reviews.apache.org/r/35130/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message