ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower" <tbeerbo...@hortonworks.com>
Subject Re: Review Request 35572: HIve View Enahancements
Date Wed, 17 Jun 2015 17:56:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35572/#review88249
-----------------------------------------------------------

Ship it!


Ship It!

- Tom Beerbower


On June 17, 2015, 5:49 p.m., Erik Bergenholtz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35572/
> -----------------------------------------------------------
> 
> (Updated June 17, 2015, 5:49 p.m.)
> 
> 
> Review request for Ambari, Robert Levas and Tom Beerbower.
> 
> 
> Bugs: AMBARI-11958
>     https://issues.apache.org/jira/browse/AMBARI-11958
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Removes non-global set properties and corrects UDF
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/components/udf-tr-view.js PRE-CREATION

>   contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index.js ea2ed5d

>   contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/job-progress.js 3181f90

>   contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/open-queries.js 484df16

>   contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/query-tabs.js 7b6c222

>   contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/settings.js 787f42b

>   contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/udf.js ced29ca 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/udfs.js 437c9d0 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/visual-explain.js
8401388 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js ab73c63

>   contrib/views/hive/src/main/resources/ui/hive-web/app/models/job.js 45393db 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/services/job-progress.js PRE-CREATION

>   contrib/views/hive/src/main/resources/ui/hive-web/app/services/session.js PRE-CREATION

>   contrib/views/hive/src/main/resources/ui/hive-web/app/services/settings.js PRE-CREATION

>   contrib/views/hive/src/main/resources/ui/hive-web/app/styles/app.scss 7be5dcc 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/templates/components/udf-tr-view.hbs
PRE-CREATION 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/templates/index.hbs 2fdf0ce 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/templates/settings-global.hbs
0712ec2 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/templates/settings-query.hbs
3d28d9b 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/templates/settings.hbs 31b9cff

>   contrib/views/hive/src/main/resources/ui/hive-web/app/templates/udfs.hbs 9d057db 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/utils/constants.js 0539463 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/views/visual-explain.js d2a800c

>   contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/controllers/index-test.js
3ac9d8a 
>   contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/controllers/insert-udfs-test.js
6f20024 
>   contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/controllers/settings-test.js
b8748cb 
>   contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/controllers/tez-ui-test.js
e03b561 
>   contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/controllers/udf-test.js
8fd643e 
>   contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/services/settings-test.js
PRE-CREATION 
>   contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/AmbariApi.java
fcf070d 
>   contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/Services.java
9ee6628 
> 
> Diff: https://reviews.apache.org/r/35572/diff/
> 
> 
> Testing
> -------
> 
> Deployment of built view on cluster. Manual testing of new features + local unit tests
of hive view (incl. new tests):
> -------------------------------------------------------
>  T E S T S
> -------------------------------------------------------
> Running org.apache.ambari.view.hive.backgroundjobs.BackgroundJobControllerTest
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.478 sec
> Running org.apache.ambari.view.hive.PropertyValidatorTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.124 sec
> Running org.apache.ambari.view.hive.resources.files.FileServiceTest
> Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.137 sec
> Running org.apache.ambari.view.hive.resources.jobs.AggregatorTest
> Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.232 sec
> Running org.apache.ambari.view.hive.resources.jobs.ATSParserTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.168 sec
> Running org.apache.ambari.view.hive.resources.jobs.JobServiceTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.01 sec
> Running org.apache.ambari.view.hive.resources.jobs.LogParserTest
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.079 sec
> Running org.apache.ambari.view.hive.resources.resources.FileResourceServiceTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.68 sec
> Running org.apache.ambari.view.hive.resources.savedQueries.SavedQueryResourceManagerTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.151 sec
> Running org.apache.ambari.view.hive.resources.savedQueries.SavedQueryServiceTest
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.796 sec
> Running org.apache.ambari.view.hive.resources.udfs.UDFServiceTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.687 sec
> 
> Results :
> 
> Tests run: 48, Failures: 0, Errors: 0, Skipped: 0
> 
> 
> Thanks,
> 
> Erik Bergenholtz
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message