ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Di Li" <>
Subject Review Request 35352: AMBARI-11810: Rolling upgrade does not run pre-upgrade checks against non-HDP stack
Date Thu, 11 Jun 2015 12:17:43 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for Ambari and Alejandro Fernandez.

Bugs: AMBARI-11810

Repository: ambari


All the rolling upgrade pre-checks may still need to run against a non-HDP stack. Use this
JIRA to make the check runnable based on properties (rollingupgrade.stack, rollingupgrade.version)
set in the /etc/ambari-server/conf/ Still default to HDP and if
the properties do not exist.

org.apache.ambari.server.checks.AbstractCheckDescriptor compares stack against hardcoded StackInfo
"HDP-2.2". the stack name and version info can be externalized into the /etc/ambari-server/conf/
in order to support non-HDP stacks.





Added new unit tests

Manually tested the fix by kicking off the rolling upgrade
1. With no properties in /etc/ambari-server/conf/, Java code used the default
HDP-2.2 StackId information and performed the upgrade pre-checks.
2. With wrong property values in, Java code threw err about the StackId
did not match
3. With correct property values in, Java code used the stack id and performed
the upgrade pre-checks.


Di Li

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message