ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 35135: AMBARI-11700: YarnTimelineServerStatePreservingCheck does not run when rolling upgrade a non-HDP stack
Date Tue, 09 Jun 2015 18:47:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35135/#review87259
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On June 5, 2015, 2:36 p.m., Di Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35135/
> -----------------------------------------------------------
> 
> (Updated June 5, 2015, 2:36 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-11700
>     https://issues.apache.org/jira/browse/AMBARI-11700
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The goal of this JIRA is to support running the YarnTimelineServerStatePreservingCheck
against non-HDP stacks, by externalizing the stack name and verison.
> 
> The YarnTimelineServerStatePreservingCheck class skips running the check when the rolling
upgrade is for non-HDP stack, due to the comparison against hardcoded stack name "HDP" and
version value "2.2.4.2".
> 
> The check may still need to run against a non-HDP stack. Use this JIRA to make the check
runnable based on properties (rollingupgrade.stack, rollingupgrade.version) set in the /etc/ambari-server/conf/ambari.properties.
Still default to HDP and 2.2.4.2 if the properties do not exist.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheck.java
ef7cbff 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
4536b3c 
>   ambari-server/src/test/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheckTest.java
4f2da3b 
> 
> Diff: https://reviews.apache.org/r/35135/diff/
> 
> 
> Testing
> -------
> 
> updated unit test. manual test by kicking off the rolling upgrade
> 
> 
> Thanks,
> 
> Di Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message