ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Nettleton" <rnettle...@hortonworks.com>
Subject Re: Review Request 35251: Oozie crashes after start on blueprint install
Date Tue, 09 Jun 2015 15:09:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35251/#review87188
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
<https://reviews.apache.org/r/35251/#comment139503>

    This change to register the two updaters is fine.  I'm adding an issue here, since I don't
see any unit tests for this change.
    
    Please implement a unit test that verifies that the updaters are registered and function
properly. 
    
    Thanks.



ambari-server/src/main/resources/common-services/OOZIE/5.0.0.2.3/configuration/oozie-env.xml
<https://reviews.apache.org/r/35251/#comment139501>

    Why is this being removed in this patch?  This looks like an un-related change.



ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/metainfo.xml
<https://reviews.apache.org/r/35251/#comment139502>

    Why is this being added in this patch?  Is this change related to the oozie_heapsize issue?


- Robert Nettleton


On June 9, 2015, 2:57 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35251/
> -----------------------------------------------------------
> 
> (Updated June 9, 2015, 2:57 p.m.)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-11811
>     https://issues.apache.org/jira/browse/AMBARI-11811
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Oozie is thinking that heapsize is in kb and failing with too low
> heapsize.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
ca7b2b1 
>   ambari-server/src/main/resources/common-services/OOZIE/5.0.0.2.3/configuration/oozie-env.xml
fe80bf5 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/metainfo.xml ca82d46

> 
> Diff: https://reviews.apache.org/r/35251/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message