ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Onischuk" <aonis...@hortonworks.com>
Subject Re: Review Request 35251: Oozie crashes after start on blueprint install
Date Tue, 09 Jun 2015 14:58:31 GMT


> On June 9, 2015, 1:46 p.m., Robert Nettleton wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java,
line 129
> > <https://reviews.apache.org/r/35251/diff/1/?file=981430#file981430line129>
> >
> >     I think adding the references to Google Guice are not necessary here.  Please
see my comments above regarding this approach.  
> >     
> >     Thanks.

Closing as of code causing the issue no more exists in patch


> On June 9, 2015, 1:46 p.m., Robert Nettleton wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java,
line 2028
> > <https://reviews.apache.org/r/35251/diff/1/?file=981430#file981430line2028>
> >
> >     I believe the static updater registrations are sufficient for most cases.  
> >     
> >     Since the stacks don't supply much of this information, and since we're so late
in the release cycle for 2.1, we shouldn't be making a change like this at this time.

Closing as of code causing the issue no more exists in patch


> On June 9, 2015, 1:46 p.m., Robert Nettleton wrote:
> > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java,
line 85
> > <https://reviews.apache.org/r/35251/diff/1/?file=981438#file981438line85>
> >
> >     There don't appear to be any unit tests associated with the new capacity updaters
added here.

Closing as of code causing the issue no more exists in patch


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35251/#review87171
-----------------------------------------------------------


On June 9, 2015, 2:57 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35251/
> -----------------------------------------------------------
> 
> (Updated June 9, 2015, 2:57 p.m.)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-11811
>     https://issues.apache.org/jira/browse/AMBARI-11811
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Oozie is thinking that heapsize is in kb and failing with too low
> heapsize.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
ca7b2b1 
>   ambari-server/src/main/resources/common-services/OOZIE/5.0.0.2.3/configuration/oozie-env.xml
fe80bf5 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/metainfo.xml ca82d46

> 
> Diff: https://reviews.apache.org/r/35251/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message