ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Nettleton" <rnettle...@hortonworks.com>
Subject Re: Review Request 35217: Configuration.removeProperty() should remove all occurrences of the given property
Date Mon, 08 Jun 2015 16:20:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35217/#review87043
-----------------------------------------------------------

Ship it!


Ship It!

- Robert Nettleton


On June 8, 2015, 3:50 p.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35217/
> -----------------------------------------------------------
> 
> (Updated June 8, 2015, 3:50 p.m.)
> 
> 
> Review request for Ambari and Robert Nettleton.
> 
> 
> Bugs: AMBARI-11790
>     https://issues.apache.org/jira/browse/AMBARI-11790
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> If a property exists at multiple levels in a configuration such as in a blueprint and
in the stack, only the most advanced occurrence of the property is removed, which in this
case would be the blueprint configuration. Instead, all occurrences of the property should
be removed from the config hierarchy such that a subsequent call to getPropertyValue() for
the removed property would return null.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/Configuration.java b7b9343

>   ambari-server/src/test/java/org/apache/ambari/server/topology/ConfigurationTest.java
1b9734e 
> 
> Diff: https://reviews.apache.org/r/35217/diff/
> 
> 
> Testing
> -------
> 
> Functional Testing:
> Ensured that provided blueprint has configuration properly resolved when deploying
> 
> Unit Testing:
> - Added new tests
> - Currently running full unit test suite and will update with results prior to merging
> 
> 
> Thanks,
> 
> John Speidel
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message