ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jaimin Jetly" <jai...@hortonworks.com>
Subject Re: Review Request 34889: AMBARI-11185: Edit Repositories on an added repo version fails with 500 status code
Date Fri, 05 Jun 2015 20:37:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34889/#review86839
-----------------------------------------------------------

Ship it!


Ship It!

- Jaimin Jetly


On June 5, 2015, 2:12 p.m., Di Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34889/
> -----------------------------------------------------------
> 
> (Updated June 5, 2015, 2:12 p.m.)
> 
> 
> Review request for Ambari and Jaimin Jetly.
> 
> 
> Bugs: AMBARI-11185
>     https://issues.apache.org/jira/browse/AMBARI-11185
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> I used HDP beta build: http://s3.amazonaws.com/dev.hortonworks.com/ambari/centos6/2.x/BUILDS/2.1.0-630
> 
> On the Stack and Versions page, under Versions tab, user cannot update the repo URL of
an added Repo version. Users can add repo versions via the "Manage Versions" button, however
after the repo is added, user cannot update the repo URL anymore.
> 
> As part of the update repo URL feature introduced in Ambari 2.0, a repo version check
was added to make sure the repo added has the same version info as the one installed, due
to Ambari 2.0 's rolling upgrade limitations.
> 
> In the Ambari 2.1 build I tried, the repo version check (AmbariManagementControllerImpl.verifyRepository)
is still the Ambari 2.0 behavior where it rejects any updates of HDP 2.3 repo URL.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 223685b 
>   ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_box_view.js 4401bae 
>   ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js 7041a38

>   ambari-web/test/views/main/admin/stack_upgrade/upgrade_version_box_view_test.js 21cea1c

> 
> Diff: https://reviews.apache.org/r/34889/diff/
> 
> 
> Testing
> -------
> 
> Unit test
>   6168 tests complete (29 seconds)
> 
> Manual test via Ambari UI
> 
> 
> Thanks,
> 
> Di Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message