ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gautam Borad" <gbo...@gmail.com>
Subject Re: Review Request 35066: AMBARI-11685 : YARN repo in Ranger Admin neds to have the right value for YARN REST URL
Date Fri, 05 Jun 2015 09:41:37 GMT


> On June 4, 2015, 2:12 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py,
line 301
> > <https://reviews.apache.org/r/35066/diff/1/?file=979051#file979051line301>
> >
> >     Do these properties need default values?
> >     Before calling .upper() need to ensure that the property is not None.
> 
> Andrew Onischuk wrote:
>     Alejandro this property should be always for Yarn. Anyway if we don't have this property
we have to fail early (better), cause than logic further is not valid.

We do agree to Andrew's comment, any other issue in RR?


- Gautam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35066/#review86606
-----------------------------------------------------------


On June 4, 2015, 2 p.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35066/
> -----------------------------------------------------------
> 
> (Updated June 4, 2015, 2 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Aleksandr Kovalenko, Andrew Onischuk,
Don Bosco Durai, Sumit Mohanty, Selvamohan Neethiraj, Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-11685
>     https://issues.apache.org/jira/browse/AMBARI-11685
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari automation created YARN repo in Ranger Admin doesn't have the right value for
YARN REST URL
> Config doesn't have the required "http://" scheme in it.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-audit.xml
661f818 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
f2ccaf3 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml
ddd90e3 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-audit.xml
d064065 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-policymgr-ssl.xml
1254902 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-audit.xml
8f8de30 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-policymgr-ssl.xml
5c8d400 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-audit.xml
1106efa 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-policymgr-ssl.xml
401fa48 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/ranger-kafka-audit.xml
864d81b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/ranger-kafka-plugin-properties.xml
dc9e04e 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/ranger-kafka-policymgr-ssl.xml
6cdd80a 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-audit.xml
a70bfc6 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-policymgr-ssl.xml
b56bf4f 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml
c76afd5 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-audit.xml
7552043 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-policymgr-ssl.xml
855e6fd 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-audit.xml
2cc354a 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-plugin-properties.xml
3f14655 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-policymgr-ssl.xml
32154f3 
>   ambari-web/app/data/HDP2.2/site_properties.js 1110da0 
>   ambari-web/app/data/HDP2.3/site_properties.js 53d663c 
> 
> Diff: https://reviews.apache.org/r/35066/diff/
> 
> 
> Testing
> -------
> 
> Tested on a Centos6 cluster having Ranger, Yarn and HDFS.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message