ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower" <tbeerbo...@hortonworks.com>
Subject Re: Review Request 35078: Automatic RM URL Config
Date Thu, 04 Jun 2015 21:25:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35078/#review86723
-----------------------------------------------------------

Ship it!


Ship It!

- Tom Beerbower


On June 4, 2015, 9:24 p.m., Erik Bergenholtz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35078/
> -----------------------------------------------------------
> 
> (Updated June 4, 2015, 9:24 p.m.)
> 
> 
> Review request for Ambari, Robert Levas and Tom Beerbower.
> 
> 
> Bugs: AMBARI-11697
>     https://issues.apache.org/jira/browse/AMBARI-11697
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> - Add Automatic ResourceManager URL configuration for http/https
> - Validate that Queue capacity adds up to 100%
> - Allow spaces in certain configurations
> - Do not allow views to be created with duplicate names
> - Do not allow views to be created with empty names
> 
> 
> Diffs
> -----
> 
>   contrib/views/capacity-scheduler/pom.xml 23e5aee 
>   contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/ConfigurationService.java
b192543 
>   contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/PropertyValidator.java
64a8796 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/adapters.js b3a7110 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/assets/data/all.json PRE-CREATION

>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js
3f3999e 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components/pathInput.js
fc8f77c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueBadge.js
dad4180 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components/totalCapacity.js
4ccf969 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queue.js 019df5f

>   contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queues.js 7b69c92

>   contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/timeAgo.js 050f0c0

>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 3132c10

>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 4b722f9 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 3a61a3b 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
23ce2ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueContainer.hbs
19c6cfe 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueListItem.hbs
5659781 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/userGroupInput.hbs
8f0a7d6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/schedulerPanel.hbs
a5385fc 
>   contrib/views/capacity-scheduler/src/main/resources/ui/config.coffee 5f9bf8b 
>   contrib/views/capacity-scheduler/src/main/resources/ui/test/unit/controllers/queue_test.js
PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/view.xml 564f353 
>   contrib/views/capacity-scheduler/src/test/java/org/apache/ambari/view/capacityscheduler/PropertyValidatorTest.java
PRE-CREATION 
>   contrib/views/utils/pom.xml d56a759 
>   contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ViewUserLocal.java PRE-CREATION

>   contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/AmbariApi.java
e49eea5 
>   contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/Services.java
PRE-CREATION 
>   contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java
c3ff8bc 
>   contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsApi.java cc329d9

>   contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsUtil.java 12226ce

>   contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ViewUserLocalTest.java
PRE-CREATION 
>   contrib/views/utils/src/test/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilderTest.java
17a9c7f 
> 
> Diff: https://reviews.apache.org/r/35078/diff/
> 
> 
> Testing
> -------
> 
> Deploy of view and manual testing,
> local unit testing
> new unit tests
> 
> 
> Thanks,
> 
> Erik Bergenholtz
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message