ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Review Request 35085: Removing A Host Does Not Recalculate Aggregate Alerts
Date Thu, 04 Jun 2015 19:50:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35085/
-----------------------------------------------------------

Review request for Ambari, Nate Cole and Tom Beerbower.


Bugs: AMBARI-11699
    https://issues.apache.org/jira/browse/AMBARI-11699


Repository: ambari


Description
-------

- Deploy cluster with HBASE, 3 nodes
- Stop and delete Region Server from one of the 3 hosts.
- Alert shows wrong data even after 10 minutes.

The root cause of this is that the aggregate alerts only recalculate on a state change. We
need to explicitly force the recalculation.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/events/AggregateAlertRecalculateEvent.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertAggregateListener.java
99542ef 
  ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertServiceComponentHostListener.java
92008e3 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java ef0430e 
  ambari-server/src/main/java/org/apache/ambari/server/state/alert/AggregateDefinitionMapping.java
c63c0d4 
  ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOTest.java 6bf808d

  ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertStateChangedEventTest.java
e37f0cb 
  ambari-server/src/test/java/org/apache/ambari/server/state/cluster/AlertDataManagerTest.java
67c08ba 

Diff: https://reviews.apache.org/r/35085/diff/


Testing
-------

mvn clean test

Also, removed a host which had alerts which were aggregated and saw the aggregate alert recalculate.


Thanks,

Jonathan Hurley


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message