Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Date: Sat, 23 May 2015 00:08:18 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: dev@ambari.apache.org
Message-ID: <JIRA.12832262.1432327032000.15139.1432339698263@Atlassian.JIRA>
In-Reply-To: <JIRA.12832262.1432327032000@Atlassian.JIRA>
References: <JIRA.12832262.1432327032000@Atlassian.JIRA>
 <JIRA.12832262.1432327032853@arcas>
Subject: [jira] [Commented] (AMBARI-11351) HdfsResource does not account for
 sticky bit
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/AMBARI-11351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14557035#comment-14557035 ] 

Hadoop QA commented on AMBARI-11351:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12734930/AMBARI-11351.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in contrib/fast-hdfs-resource.

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/2843//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/2843//console

This message is automatically generated.

> HdfsResource does not account for sticky bit
> --------------------------------------------
>
>                 Key: AMBARI-11351
>                 URL: https://issues.apache.org/jira/browse/AMBARI-11351
>             Project: Ambari
>          Issue Type: Bug
>          Components: contrib
>    Affects Versions: Ambari-2.1
>         Environment: Linux
>            Reporter: Shantanu Mundkur
>            Assignee: Shantanu Mundkur
>              Labels: patch
>             Fix For: Ambari-2.1
>
>         Attachments: AMBARI-11351.patch
>
>
> Specifying a mode of 01777 will result in an exception like:
> Exception in thread "main" java.lang.IllegalArgumentException: 1777
> at org.apache.hadoop.fs.permission.PermissionParser.<init>(PermissionParser.java:60)
> at org.apache.hadoop.fs.permission.UmaskParser.<init>(UmaskParser.java:42)
> at org.apache.hadoop.fs.permission.FsPermission.<init>(FsPermission.java:106)
> at org.apache.ambari.fast_hdfs_resource.Resource.setMode(Resource.java:217)
> at org.apache.ambari.fast_hdfs_resource.Runner.main(Runner.java:78)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at org.apache.hadoop.util.RunJar.run(RunJar.java:221)
> at org.apache.hadoop.util.RunJar.main(RunJar.java:136)
> In fast_hdfs_resource, setMode is used to set the permissions on the Resource object using the specified mode. Passing in the mode as a string for FsPermission is what results in the problem because the constructor that is used with string as argument uses the UmaskParser. Umask values are slightly different from standard modes as they cannot specify t (sticky bit) or X.
> Passing in the argument as a short is probably what is needed here to enable using the FsPermission code that accounts for the sticky bit.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)