Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A9C8B18906 for ; Fri, 29 May 2015 22:21:58 +0000 (UTC) Received: (qmail 57400 invoked by uid 500); 29 May 2015 22:21:58 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 57360 invoked by uid 500); 29 May 2015 22:21:58 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 57336 invoked by uid 99); 29 May 2015 22:21:58 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 May 2015 22:21:58 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8EC771DDCE1; Fri, 29 May 2015 22:21:56 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3135066967553765958==" MIME-Version: 1.0 Subject: Re: Review Request 34824: AMBARI-11537 : Fixes required for SSL Issues on Ranger with new properties From: "Alejandro Fernandez" To: "Srimanth Gunturi" , "Selvamohan Neethiraj" , "Andrew Onischuk" , "Alejandro Fernandez" , "Aleksandr Kovalenko" , "Velmurugan Periasamy" Cc: "Gautam Borad" , "Ambari" Date: Fri, 29 May 2015 22:21:56 -0000 Message-ID: <20150529222156.8664.20967@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Alejandro Fernandez" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/34824/ X-Sender: "Alejandro Fernandez" References: <20150529192829.8664.6855@reviews.apache.org> In-Reply-To: <20150529192829.8664.6855@reviews.apache.org> Reply-To: "Alejandro Fernandez" X-ReviewRequest-Repository: ambari --===============3135066967553765958== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34824/#review85827 ----------------------------------------------------------- ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py This needs to check if the property above is valid. ranger_admin_hosts = default('/clusterHostInfo/ranger_admin_hosts', []) ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/service_check.py Are there any other valid response codes besides 200? ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py Does the credential_file directory need to be created first? ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml Does this need a description? ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-default.json Can you remove all of the unrelated properties for Spark, Kafka, etc.? - Alejandro Fernandez On May 29, 2015, 7:28 p.m., Gautam Borad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34824/ > ----------------------------------------------------------- > > (Updated May 29, 2015, 7:28 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Aleksandr Kovalenko, Andrew Onischuk, Selvamohan Neethiraj, Srimanth Gunturi, and Velmurugan Periasamy. > > > Bugs: AMBARI-11537 > https://issues.apache.org/jira/browse/AMBARI-11537 > > > Repository: ambari > > > Description > ------- > > Added the following fixes for Ranger to support SSL with new properties > 1] conf/cert/unixauthservice.jks file is not copied during install > 2] UnixAuthenticationService is looking for usersync.ssl.key.password, but Ambari setup scripts are updating the credential store with usersync_ssl_key_password. > 3] Use ranger.service.http.port instead of kms_port (in KMS) > > > Diffs > ----- > > ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py cfa51da > ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/admin-properties.xml 1862f37 > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 7a6dacf > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/service_check.py 0a2f5ae > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py d845eb4 > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-site.xml 5446dcd > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 9f274bc > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 9b806eb > ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-audit.xml b7f80b9 > ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-audit.xml a2b6362 > ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-audit.xml 057978f > ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/ranger-kafka-audit.xml 6aa5101 > ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-audit.xml d20a68b > ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml b9da3a5 > ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-ugsync-site.xml acd77a1 > ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-audit.xml ad08922 > ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-audit.xml 776b000 > ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_admin.py 8448bf5 > ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_usersync.py 6464efc > ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-default.json PRE-CREATION > ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-secured.json PRE-CREATION > ambari-web/app/data/HDP2.3/site_properties.js 3527e17 > > Diff: https://reviews.apache.org/r/34824/diff/ > > > Testing > ------- > > Tested on a centos6 clusted with Ranger / Ranger KMS and enabled SSL. > > ---------------------------------------------------------------------- > Ran 235 tests in 7.472s > > OK > ---------------------------------------------------------------------- > Total run:744 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Gautam Borad > > --===============3135066967553765958==--