Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6593C172BA for ; Fri, 29 May 2015 01:43:22 +0000 (UTC) Received: (qmail 86479 invoked by uid 500); 29 May 2015 01:43:22 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 86450 invoked by uid 500); 29 May 2015 01:43:22 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 86433 invoked by uid 99); 29 May 2015 01:43:22 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 May 2015 01:43:22 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C16E81DDAE6; Fri, 29 May 2015 01:43:20 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6971534283940920844==" MIME-Version: 1.0 Subject: Re: Review Request 34557: Add Service Wizard requests KDC information when cluster is configured for Manual Kerberos From: "Robert Levas" To: "Andrii Tkach" , "Yusaku Sako" , "Aleksandr Kovalenko" , "Jaimin Jetly" Cc: "Robert Levas" , "Ambari" Date: Fri, 29 May 2015 01:43:20 -0000 Message-ID: <20150529014320.9497.64656@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Robert Levas" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/34557/ X-Sender: "Robert Levas" References: <20150521182459.17474.44525@reviews.apache.org> In-Reply-To: <20150521182459.17474.44525@reviews.apache.org> Reply-To: "Robert Levas" X-ReviewRequest-Repository: ambari --===============6971534283940920844== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34557/#review85668 ----------------------------------------------------------- Ship it! Ship It! - Robert Levas On May 21, 2015, 2:24 p.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34557/ > ----------------------------------------------------------- > > (Updated May 21, 2015, 2:24 p.m.) > > > Review request for Ambari, Aleksandr Kovalenko, Andrii Tkach, Jaimin Jetly, and Yusaku Sako. > > > Bugs: AMBARI-11247 > https://issues.apache.org/jira/browse/AMBARI-11247 > > > Repository: ambari > > > Description > ------- > > Add Service Wizard requests KDC information when cluster is configured for Manual Kerberos. > > When configured for Kerberos with the _Manual_ option, the _Add Host Wizard_ should not warn about or prompt for KDC details. The _wizard_ should also allow the user to download a CSV file of expected (user-generated) principals and keytabs files from the Review (or conformation page). > Additional working on the Review/Confirmation page may be needed to inform the user that they should create the principals and keytabs before continuing. > > To know whether the cluster is configured for _manual kerberos_: > * Cluster.security_type = "KERBEROS" > * kerberos-env/manage_identities = "false" > > > Diffs > ----- > > ambari-web/app/controllers/main/admin/kerberos.js 47ca736 > ambari-web/app/controllers/main/admin/kerberos/step4_controller.js a48baaf > ambari-web/app/controllers/wizard/step8_controller.js 0e1b777 > ambari-web/app/routes/add_service_routes.js 3db7879 > ambari-web/app/styles/application.less 65241eb > ambari-web/app/templates/wizard/step8.hbs 8506371 > ambari-web/app/utils/ajax/ajax.js 943c3f6 > ambari-web/test/controllers/main/admin/kerberos/step4_controller_test.js 780bc00 > ambari-web/test/controllers/main/admin/kerberos_test.js 30bddb7 > ambari-web/test/controllers/wizard/step8_test.js d65c145 > > Diff: https://reviews.apache.org/r/34557/diff/ > > > Testing > ------- > > Manual testing. > > > Thanks, > > Robert Levas > > --===============6971534283940920844==--