Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5850B181D6 for ; Thu, 28 May 2015 14:55:18 +0000 (UTC) Received: (qmail 33011 invoked by uid 500); 28 May 2015 14:54:56 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 32989 invoked by uid 500); 28 May 2015 14:54:56 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 32975 invoked by uid 99); 28 May 2015 14:54:55 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 May 2015 14:54:55 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id AB4DA1DDAF2; Thu, 28 May 2015 14:54:54 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9058100592571257093==" MIME-Version: 1.0 Subject: Review Request 34768: Changed Configurations During Upgrade Are Reverted During Finalize From: "Jonathan Hurley" To: "Nate Cole" , "Tom Beerbower" Cc: "Ambari" , "Jonathan Hurley" Date: Thu, 28 May 2015 14:54:54 -0000 Message-ID: <20150528145454.9497.95983@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jonathan Hurley" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/34768/ X-Sender: "Jonathan Hurley" Reply-To: "Jonathan Hurley" X-ReviewRequest-Repository: ambari --===============9058100592571257093== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34768/ ----------------------------------------------------------- Review request for Ambari, Nate Cole and Tom Beerbower. Bugs: AMBARI-11487 https://issues.apache.org/jira/browse/AMBARI-11487 Repository: ambari Description ------- During a rolling upgrade from HDP 2.2 to HDP 2.3, several components such as MapR and Storm have their new HDP 2.3 configurations updated with {{ConfigureTask}} changes from the upgrade pack. The database reflects the correct changes up until {{FinalizeUpgradeAction}} is invoked, after which the original HDP 2.3 values are re-inserted. Diffs ----- ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java 0ac952c ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 1543ad7 ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 98f7cfc ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 710c046 Diff: https://reviews.apache.org/r/34768/diff/ Testing ------- mvn clean test Thanks, Jonathan Hurley --===============9058100592571257093==--