Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EE47117880 for ; Fri, 22 May 2015 16:24:44 +0000 (UTC) Received: (qmail 93330 invoked by uid 500); 22 May 2015 16:24:44 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 93298 invoked by uid 500); 22 May 2015 16:24:44 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 93282 invoked by uid 99); 22 May 2015 16:24:44 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 May 2015 16:24:44 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1A0341D70AA; Fri, 22 May 2015 16:24:44 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7734601294702180977==" MIME-Version: 1.0 Subject: Re: Review Request 34352: Make Kafka Metrics Reporter agnostic to the metrics names size From: "Sid Wagle" To: "Sid Wagle" , "Robert Levas" , "Costel Radulescu" , "Florian Barca" Cc: "Emil Anca" , "Ambari" Date: Fri, 22 May 2015 16:24:44 -0000 Message-ID: <20150522162444.17212.3548@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Sid Wagle" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/34352/ X-Sender: "Sid Wagle" References: <20150519113425.14202.503@reviews.apache.org> In-Reply-To: <20150519113425.14202.503@reviews.apache.org> Reply-To: "Sid Wagle" X-ReviewRequest-Repository: ambari --===============7734601294702180977== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34352/#review84927 ----------------------------------------------------------- Ship it! Ship It! - Sid Wagle On May 19, 2015, 11:34 a.m., Emil Anca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34352/ > ----------------------------------------------------------- > > (Updated May 19, 2015, 11:34 a.m.) > > > Review request for Ambari, Costel Radulescu, Florian Barca, Robert Levas, and Sid Wagle. > > > Bugs: AMBARI-11211 > https://issues.apache.org/jira/browse/AMBARI-11211 > > > Repository: ambari > > > Description > ------- > > Problem: Processing histograms and timers has hardcoded number of expected metric names > Solution: Replaced with array union via apache-commons > > > Diffs > ----- > > ambari-metrics/ambari-metrics-kafka-sink/pom.xml a4361b0 > ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java 00a58ee > > Diff: https://reviews.apache.org/r/34352/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Emil Anca > > --===============7734601294702180977==--