Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D3C3710A61 for ; Tue, 19 May 2015 19:00:47 +0000 (UTC) Received: (qmail 69332 invoked by uid 500); 19 May 2015 19:00:47 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 69301 invoked by uid 500); 19 May 2015 19:00:47 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 69283 invoked by uid 99); 19 May 2015 19:00:47 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 May 2015 19:00:47 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 764021DD549; Tue, 19 May 2015 19:00:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7604792959801036465==" MIME-Version: 1.0 Subject: Re: Review Request 34171: Allow NFS mounts to be skipped during agent health check From: "Dmytro Sen" To: "Andrew Onischuk" , "Sid Wagle" , "Dmitro Lisnichenko" Cc: "Ambari" , "Dmytro Sen" , "Myroslav Papirkovskyy" , "Vitalyi Brodetskyi" Date: Tue, 19 May 2015 19:00:46 -0000 Message-ID: <20150519190046.14202.67568@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Dmytro Sen" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/34171/ X-Sender: "Dmytro Sen" References: <20150519155046.14202.39376@reviews.apache.org> In-Reply-To: <20150519155046.14202.39376@reviews.apache.org> Reply-To: "Dmytro Sen" X-ReviewRequest-Repository: ambari --===============7604792959801036465== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34171/ ----------------------------------------------------------- (Updated Май 19, 2015, 7 п.п.) Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Sid Wagle. Bugs: AMBARI-10882 https://issues.apache.org/jira/browse/AMBARI-10882 Repository: ambari Description ------- The 'df' checks traverses the entire fstab (including the automounted user directories). This causes the timeout for each mounted user directory to reset. And since we are checking so often (even every few heartbeats), these automounted user directory never unmount. Adding the '-l' to the 'df' check, would only parse the local disks, and allow the automounted user folders to timeout properly. This should be a configurable property to skip or not. Diffs (updated) ----- ambari-agent/conf/unix/ambari-agent.ini 173bb51 ambari-agent/conf/windows/ambari-agent.ini 61a3ad9 ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 13e9f03 ambari-agent/src/main/python/ambari_agent/Controller.py ccd1233 ambari-agent/src/main/python/ambari_agent/Hardware.py 5fbe2f8 ambari-agent/src/main/python/ambari_agent/Heartbeat.py 27aef04 ambari-agent/src/main/python/ambari_agent/HostInfo.py 98c8045 ambari-agent/src/main/python/ambari_agent/RecoveryManager.py 12ba75d ambari-agent/src/test/python/ambari_agent/TestHardware.py 8a3d257 ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 9af45ac ambari-agent/src/test/python/unitTests.py cb7a64f ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java ab17db6 ambari-server/src/main/java/org/apache/ambari/server/agent/RegistrationResponse.java 8768a46 ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java d8f89b2 ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 39192c4 Diff: https://reviews.apache.org/r/34171/diff/ Testing ------- Unit tests are in progress Thanks, Dmytro Sen --===============7604792959801036465==--