Return-Path: 
 <dev-return-71916-apmail-ambari-dev-archive=ambari.apache.org@ambari.apache.org>
X-Original-To: apmail-ambari-dev-archive@www.apache.org
Delivered-To: apmail-ambari-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 37EDB17EAC
	for <apmail-ambari-dev-archive@www.apache.org>;
 Mon, 18 May 2015 20:17:41 +0000 (UTC)
Received: (qmail 50589 invoked by uid 500); 18 May 2015 20:17:41 -0000
Delivered-To: apmail-ambari-dev-archive@ambari.apache.org
Received: (qmail 50571 invoked by uid 500); 18 May 2015 20:17:41 -0000
Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@ambari.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@ambari.apache.org>
List-Post: <mailto:dev@ambari.apache.org>
List-Id: <dev.ambari.apache.org>
Reply-To: dev@ambari.apache.org
Delivered-To: mailing list dev@ambari.apache.org
Received: (qmail 50557 invoked by uid 99); 18 May 2015 20:17:40 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 May 2015 20:17:40 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 103A61DD4D7;
	Mon, 18 May 2015 20:17:40 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============8840443340433018785=="
MIME-Version: 1.0
Subject: Re: Review Request 34363: Tez Upgrade Pack For HDP-2.2 to HDP-2.3
From: "Jonathan Hurley" <jhurley@hortonworks.com>
To: "Alejandro Fernandez" <afernandez@hortonworks.com>,
 "Nate Cole" <ncole@hortonworks.com>
Cc: "Ambari" <dev@ambari.apache.org>,
 "Jonathan Hurley" <jhurley@hortonworks.com>
Date: Mon, 18 May 2015 20:17:40 -0000
Message-ID: <20150518201740.14201.79511@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org/
Auto-Submitted: auto-generated
Sender: "Jonathan Hurley" <noreply@reviews.apache.org>
X-ReviewGroup: Ambari
X-ReviewRequest-URL: https://reviews.apache.org/r/34363/
X-Sender: "Jonathan Hurley" <noreply@reviews.apache.org>
References: <20150518201618.14202.382@reviews.apache.org>
In-Reply-To: <20150518201618.14202.382@reviews.apache.org>
Reply-To: "Jonathan Hurley" <jhurley@hortonworks.com>
X-ReviewRequest-Repository: ambari

--===============8840443340433018785==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit



> On May 18, 2015, 4:16 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py, line 174
> > <https://reviews.apache.org/r/34363/diff/1/?file=962956#file962956line174>
> >
> >     If current_hdp_version is None, due to some error, then this not update stack_version, so the wrong balue will be used.
> >     At a minimum, we should log it.

I don't think this can be None as an exception is thrown if it can't be determined.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34363/#review84206
-----------------------------------------------------------


On May 18, 2015, 1:11 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34363/
> -----------------------------------------------------------
> 
> (Updated May 18, 2015, 1:11 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
> 
> 
> Bugs: AMBARI-11220
>     https://issues.apache.org/jira/browse/AMBARI-11220
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In the latest version of Tez, additional security controls ( ACLs) were introduced. To provide the same level of access control as the previous version (i.e. no access controls), add the following property to tez-site.xml: 
> {code}
> <property>
>   <name>tez.am.view-acls</name>
>   <value>*</value>
> </property>
> {code}
> 
> Additionally, we are also now setting the property “tez.task.generate.counters.per.io” to true in the latest release. However, this is not a critical config that needs to be applied as part of the rolling upgrade.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py 7c5c005 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 1e183de 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py abff479 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/params.py 3031a9f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py 9d57c18 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 889dbd1 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 8905561 
> 
> Diff: https://reviews.apache.org/r/34363/diff/
> 
> 
> Testing
> -------
> 
> Upgrade HDP 2.2 to 2.3 with Tez + core hadoop.
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


--===============8840443340433018785==--