Return-Path: 
 <dev-return-71915-apmail-ambari-dev-archive=ambari.apache.org@ambari.apache.org>
X-Original-To: apmail-ambari-dev-archive@www.apache.org
Delivered-To: apmail-ambari-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id A636317EAA
	for <apmail-ambari-dev-archive@www.apache.org>;
 Mon, 18 May 2015 20:17:33 +0000 (UTC)
Received: (qmail 50249 invoked by uid 500); 18 May 2015 20:17:33 -0000
Delivered-To: apmail-ambari-dev-archive@ambari.apache.org
Received: (qmail 50217 invoked by uid 500); 18 May 2015 20:17:33 -0000
Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@ambari.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@ambari.apache.org>
List-Post: <mailto:dev@ambari.apache.org>
List-Id: <dev.ambari.apache.org>
Reply-To: dev@ambari.apache.org
Delivered-To: mailing list dev@ambari.apache.org
Received: (qmail 50203 invoked by uid 99); 18 May 2015 20:17:33 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 May 2015 20:17:33 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 621DC1DD4D7;
	Mon, 18 May 2015 20:17:32 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============6877484652576479741=="
MIME-Version: 1.0
Subject: Re: Review Request 34367: Views: attempt to save cluster-related view
 fails w/o default value
From: "Nate Cole" <ncole@hortonworks.com>
To: "Nate Cole" <ncole@hortonworks.com>,
 "Jonathan Hurley" <jhurley@hortonworks.com>
Cc: "Ambari" <dev@ambari.apache.org>,
 "Tom Beerbower" <tbeerbower@hortonworks.com>
Date: Mon, 18 May 2015 20:17:32 -0000
Message-ID: <20150518201732.14201.31209@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org/
Auto-Submitted: auto-generated
Sender: "Nate Cole" <noreply@reviews.apache.org>
X-ReviewGroup: Ambari
X-ReviewRequest-URL: https://reviews.apache.org/r/34367/
X-Sender: "Nate Cole" <noreply@reviews.apache.org>
References: <20150518195229.14202.24570@reviews.apache.org>
In-Reply-To: <20150518195229.14202.24570@reviews.apache.org>
Reply-To: "Nate Cole" <ncole@hortonworks.com>
X-ReviewRequest-Repository: ambari

--===============6877484652576479741==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34367/#review84208
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On May 18, 2015, 3:52 p.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34367/
> -----------------------------------------------------------
> 
> (Updated May 18, 2015, 3:52 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-11224
>     https://issues.apache.org/jira/browse/AMBARI-11224
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Don't enforce 'required' validation for cluster config parameters since the value will be obtained through cluster association, not user input.
>           
> Fails to create a view unless <default-value> is specified. A view instance should be create'able with cluster association even if it doesn't have a default value as long as it has cluster-config.
> 
> Error is "No property values exist for the required parameter..."
>  
> 
>   <parameter>
>     <name>cluster.url</name>
>     <description>Enter Ambari Server Cluster URL</description>
>     <placeholder>http://ambari.server:8080/api/v1/clusters/MyCluster</placeholder>
>     <cluster-config>yarn-env/yarn_user</cluster-config>
>     <required>true</required>
>   </parameter>
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java 6855b56 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/entities/ViewInstanceEntityTest.java 036fa03 
> 
> Diff: https://reviews.apache.org/r/34367/diff/
> 
> 
> Testing
> -------
> 
> Manual test.
> 
> New unit test added.
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>


--===============6877484652576479741==--