Return-Path: 
 <dev-return-71594-apmail-ambari-dev-archive=ambari.apache.org@ambari.apache.org>
X-Original-To: apmail-ambari-dev-archive@www.apache.org
Delivered-To: apmail-ambari-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id E5E231818A
	for <apmail-ambari-dev-archive@www.apache.org>;
 Fri, 15 May 2015 17:49:53 +0000 (UTC)
Received: (qmail 49293 invoked by uid 500); 15 May 2015 17:49:53 -0000
Delivered-To: apmail-ambari-dev-archive@ambari.apache.org
Received: (qmail 49261 invoked by uid 500); 15 May 2015 17:49:53 -0000
Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@ambari.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@ambari.apache.org>
List-Post: <mailto:dev@ambari.apache.org>
List-Id: <dev.ambari.apache.org>
Reply-To: dev@ambari.apache.org
Delivered-To: mailing list dev@ambari.apache.org
Received: (qmail 49246 invoked by uid 99); 15 May 2015 17:49:53 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 May 2015 17:49:53 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 263D21CC1BC;
	Fri, 15 May 2015 17:49:53 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============1426088940947306139=="
MIME-Version: 1.0
Subject: Re: Review Request 34279: ConfigureTask For Upgrades Must Support
 Type
 Coercion
From: "Tom Beerbower" <tbeerbower@hortonworks.com>
To: "Nate Cole" <ncole@hortonworks.com>,
 "Tom Beerbower" <tbeerbower@hortonworks.com>
Cc: "Jonathan Hurley" <jhurley@hortonworks.com>,
 "Ambari" <dev@ambari.apache.org>
Date: Fri, 15 May 2015 17:49:53 -0000
Message-ID: <20150515174953.1461.27433@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org/
Auto-Submitted: auto-generated
Sender: "Tom Beerbower" <noreply@reviews.apache.org>
X-ReviewGroup: Ambari
X-ReviewRequest-URL: https://reviews.apache.org/r/34279/
X-Sender: "Tom Beerbower" <noreply@reviews.apache.org>
References: <20150515165130.1460.30469@reviews.apache.org>
In-Reply-To: <20150515165130.1460.30469@reviews.apache.org>
Reply-To: "Tom Beerbower" <tbeerbower@hortonworks.com>
X-ReviewRequest-Repository: ambari

--===============1426088940947306139==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34279/#review83948
-----------------------------------------------------------

Ship it!


Ship It!

- Tom Beerbower


On May 15, 2015, 4:51 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34279/
> -----------------------------------------------------------
> 
> (Updated May 15, 2015, 4:51 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Tom Beerbower.
> 
> 
> Bugs: AMBARI-11177
>     https://issues.apache.org/jira/browse/AMBARI-11177
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The ConfigureTask must be able to support type coercion when copying values between stacks. This will enable data transformation during an upgrade. In particular, this solves the issue of a configuration type being changed between stack versions.
> 
> <transfer operation="copy" from-key="nimbus.host" to-key="nimbus.seeds" coerce-to="yaml-array" />
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java 645c4bb 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java 2b68a28 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/TransferCoercionType.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/TransferOperation.java 1ee2a35 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml eb89dbd 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java 99882fd 
> 
> Diff: https://reviews.apache.org/r/34279/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


--===============1426088940947306139==--