Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============8952648714325164988=="
MIME-Version: 1.0
Subject: Re: Review Request 34246: Upgrade Is Allowed When A Service Is
 Installed After Distribute Repositories
From: "Jonathan Hurley" <jhurley@hortonworks.com>
To: "Nate Cole" <ncole@hortonworks.com>,
 "Dmitro Lisnichenko" <dlysnichenko@hortonworks.com>,
 "Jonathan Hurley" <jhurley@hortonworks.com>
Cc: "Alejandro Fernandez" <afernandez@hortonworks.com>,
 "Ambari" <dev@ambari.apache.org>
Date: Fri, 15 May 2015 03:54:19 -0000
Message-ID: <20150515035419.1461.78273@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Jonathan Hurley" <noreply@reviews.apache.org>
References: <20150515002953.1461.46826@reviews.apache.org>
In-Reply-To: <20150515002953.1461.46826@reviews.apache.org>
Reply-To: "Jonathan Hurley" <jhurley@hortonworks.com>

--===============8952648714325164988==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34246/#review83892
-----------------------------------------------------------

Ship it!


Just a minor comment; I think we can use StackId equality comparison directly here. If I'm wrong then just close the issue I opened.


ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java
<https://reviews.apache.org/r/34246/#comment134972>

    StackId implements equals() ... no need to convert them to strings, right?


- Jonathan Hurley


On May 14, 2015, 8:29 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34246/
> -----------------------------------------------------------
> 
> (Updated May 14, 2015, 8:29 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-11146
>     https://issues.apache.org/jira/browse/AMBARI-11146
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> was done before the service was added.
> 
> STR:
> * Install base services like HDFS and YARN
> * Distribute new repository
> * Install HBase
> * Attempt upgrade
> 
> At this point two things should happen:
> The web client should not allow the upgrade to happen
> The pre-upgrade check HostsRepositoryVersionCheck should prevent the upgrade.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java 8c8f978 
>   ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java aa8b860 
>   ambari-server/src/test/java/org/apache/ambari/server/utils/EventBusSynchronizer.java 4b0c031 
> 
> Diff: https://reviews.apache.org/r/34246/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> Reproduced the issue on a local cluster, and verified that the fix worked by Installing a new version, then adding a service, which marked the host_version and single cluster_version record as OUT_OF_SYNC.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


--===============8952648714325164988==--