Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AE47318601 for ; Fri, 15 May 2015 00:05:08 +0000 (UTC) Received: (qmail 26659 invoked by uid 500); 15 May 2015 00:05:08 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 26623 invoked by uid 500); 15 May 2015 00:05:08 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 26609 invoked by uid 99); 15 May 2015 00:05:08 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 May 2015 00:05:08 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id EE9E51DD48A; Fri, 15 May 2015 00:05:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2598368340305567091==" MIME-Version: 1.0 Subject: Re: Review Request 34243: [WinTP2] Ambari Windows services description should not include version From: "Florian Barca" To: "Jayush Luniya" , "Florian Barca" Cc: "Artem Baranchuk" , "Ambari" Date: Fri, 15 May 2015 00:05:07 -0000 Message-ID: <20150515000507.1461.5100@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Florian Barca" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/34243/ X-Sender: "Florian Barca" References: <20150514235617.1461.65843@reviews.apache.org> In-Reply-To: <20150514235617.1461.65843@reviews.apache.org> Reply-To: "Florian Barca" X-ReviewRequest-Repository: ambari --===============2598368340305567091== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On May 14, 2015, 11:56 p.m., Florian Barca wrote: > > Ship It! The display name is still version-dependent, which is something the work item doesn't mention. - Florian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34243/#review83873 ----------------------------------------------------------- On May 14, 2015, 11:50 p.m., Artem Baranchuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34243/ > ----------------------------------------------------------- > > (Updated May 14, 2015, 11:50 p.m.) > > > Review request for Ambari, Florian Barca and Jayush Luniya. > > > Bugs: AMBARI-11150 > https://issues.apache.org/jira/browse/AMBARI-11150 > > > Repository: ambari > > > Description > ------- > > [WinTP2] Ambari Windows services description should not include version > > > Diffs > ----- > > ambari-common/src/main/python/ambari_commons/ambari_service.py 391ddc3 > > Diff: https://reviews.apache.org/r/34243/diff/ > > > Testing > ------- > > tested manually > > > Thanks, > > Artem Baranchuk > > --===============2598368340305567091==--