Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 282C417D68 for ; Thu, 7 May 2015 21:10:01 +0000 (UTC) Received: (qmail 1890 invoked by uid 500); 7 May 2015 21:10:01 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 1855 invoked by uid 500); 7 May 2015 21:10:01 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 1808 invoked by uid 99); 7 May 2015 21:10:00 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 May 2015 21:10:00 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DAFBC1DD201; Thu, 7 May 2015 21:10:01 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4337946296114995465==" MIME-Version: 1.0 Subject: Re: Review Request 33906: AMBARI-10752 Update Accumulo config defaults and ambari-web site properties From: "Jaimin Jetly" To: "Jaimin Jetly" Cc: "Billie Rinaldi" , "Ambari" Date: Thu, 07 May 2015 21:10:01 -0000 Message-ID: <20150507211001.1562.63538@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jaimin Jetly" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/33906/ X-Sender: "Jaimin Jetly" References: <20150506232854.1563.36772@reviews.apache.org> In-Reply-To: <20150506232854.1563.36772@reviews.apache.org> Reply-To: "Jaimin Jetly" X-ReviewRequest-Repository: ambari --===============4337946296114995465== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33906/#review82910 ----------------------------------------------------------- Ship it! Ship It! - Jaimin Jetly On May 6, 2015, 11:28 p.m., Billie Rinaldi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33906/ > ----------------------------------------------------------- > > (Updated May 6, 2015, 11:28 p.m.) > > > Review request for Ambari and Jaimin Jetly. > > > Repository: ambari > > > Description > ------- > > This patch resolves several issues we’ve been seeing in tests, mostly by tweaking the default config values and also adjusting how some of the config files are created. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java 68a45ec > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-env.xml dfec771 > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-site.xml 8e6406c > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/metainfo.xml 7a6004c > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/files/gc 63fb8bb > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/files/masters 63fb8bb > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/files/monitor 63fb8bb > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/files/slaves 63fb8bb > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/files/tracers 63fb8bb > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py 4652cc1 > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_service.py 13411e6 > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py 4fc9bed > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/templates/gc.j2 PRE-CREATION > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/templates/masters.j2 PRE-CREATION > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/templates/monitor.j2 PRE-CREATION > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/templates/slaves.j2 PRE-CREATION > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/templates/tracers.j2 PRE-CREATION > ambari-server/src/main/resources/role_command_order.json 650e2e7 > ambari-server/src/main/resources/stacks/HDP/2.2/role_command_order.json 2e2aef6 > ambari-web/app/controllers/wizard/step8_controller.js bdfa292 > ambari-web/app/data/HDP2/site_properties.js ae6051f > ambari-web/app/models/stack_service.js 1a940e8 > > Diff: https://reviews.apache.org/r/33906/diff/ > > > Testing > ------- > > I have tested the patch locally on VMs and verified that the configuration files are created correctly and the configs appear in the UI as expected. > > Also ran "mvn clean test" successfully. > > > Thanks, > > Billie Rinaldi > > --===============4337946296114995465==--