Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 003E4102C2 for ; Thu, 7 May 2015 05:19:34 +0000 (UTC) Received: (qmail 26031 invoked by uid 500); 7 May 2015 05:19:33 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 26006 invoked by uid 500); 7 May 2015 05:19:33 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 25558 invoked by uid 99); 7 May 2015 05:19:33 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 May 2015 05:19:33 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8FE681DC58A; Thu, 7 May 2015 05:19:34 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1988158379633637431==" MIME-Version: 1.0 Subject: Re: Review Request 33932: Implement persistence for topology manager From: "Mahadev Konar" To: "Mahadev Konar" Cc: "John Speidel" , "Ambari" Date: Thu, 07 May 2015 05:19:34 -0000 Message-ID: <20150507051934.1563.22731@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Mahadev Konar" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/33932/ X-Sender: "Mahadev Konar" References: <20150507051528.1563.51891@reviews.apache.org> In-Reply-To: <20150507051528.1563.51891@reviews.apache.org> Reply-To: "Mahadev Konar" X-ReviewRequest-Repository: ambari --===============1988158379633637431== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33932/#review82795 ----------------------------------------------------------- Ship it! Ship It! - Mahadev Konar On May 7, 2015, 5:15 a.m., John Speidel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33932/ > ----------------------------------------------------------- > > (Updated May 7, 2015, 5:15 a.m.) > > > Review request for Ambari and Mahadev Konar. > > > Bugs: AMBARI-10990 > https://issues.apache.org/jira/browse/AMBARI-10990 > > > Repository: ambari > > > Description > ------- > > The new TopologyManager maintains state regarding logical requests and cluster topology. This information needs to be persisted to the ambari database and replayed upon ambari server restarting. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRenderer.java 351f6b4 > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 84e1623 > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 3994a7b > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExportBlueprintRequest.java e4acea2 > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java 30627eb > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 07c0e58 > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java 3da92f1 > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ScaleClusterRequest.java f3e45aa > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java 7167449 > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyHostGroupDAO.java a11ec33 > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyHostTaskDAO.java PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyLogicalTaskDAO.java PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintEntity.java 21813ba > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyHostGroupEntity.java 3448b65 > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyHostInfoEntity.java 36c2782 > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyHostRequestEntity.java 2f42d80 > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyHostTaskEntity.java 2c31bb5 > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyLogicalRequestEntity.java 023a058 > ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java f27d4ab > ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java 07ea50b > ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopology.java e924653 > ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopologyImpl.java 84e90bf > ambari-server/src/main/java/org/apache/ambari/server/topology/HostGroupInfo.java 07cc1b2 > ambari-server/src/main/java/org/apache/ambari/server/topology/HostOfferResponse.java ce636e2 > ambari-server/src/main/java/org/apache/ambari/server/topology/HostRequest.java 9f9db5c > ambari-server/src/main/java/org/apache/ambari/server/topology/LogicalRequest.java 5273ff8 > ambari-server/src/main/java/org/apache/ambari/server/topology/LogicalRequestFactory.java PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/topology/PersistedState.java PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/topology/PersistedStateImpl.java PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/topology/PersistedTopologyRequest.java PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java fb4baec > ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyRequest.java 4c1abf9 > ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyTask.java 99783dd > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java 46fdbf4 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql d32f3cd > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4317c83 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql e3cef5d > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 77186a1 > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java 7898473 > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StageResourceProviderTest.java 96a92ad > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/TopologyLogicalRequestDAOTest.java bba45eb > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/TopologyRequestDAOTest.java b426c3f > ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java PRE-CREATION > ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterTopologyImplTest.java eef14a8 > ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/33932/diff/ > > > Testing > ------- > > Extensive functional testing. > > Unit tests: > - new test > - all existing tests pass > > > Thanks, > > John Speidel > > --===============1988158379633637431==--