Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============7085508648539760956=="
MIME-Version: 1.0
Subject: Review Request 33907: Kerberos: "Attention: Some configurations need
 your attention" msg in Enable Kerb Wizard hides fields
From: "Robert Levas" <rlevas@hortonworks.com>
To: "Yusaku Sako" <yusaku@hortonworks.com>,
 "Alexandr Antonenko" <hiveww@gmail.com>
Cc: "Robert Levas" <rlevas@hortonworks.com>, "Ambari" <dev@ambari.apache.org>
Date: Wed, 06 May 2015 19:50:48 -0000
Message-ID: <20150506195048.1562.3114@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Robert Levas" <noreply@reviews.apache.org>
Reply-To: "Robert Levas" <rlevas@hortonworks.com>

--===============7085508648539760956==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33907/
-----------------------------------------------------------

Review request for Ambari, Alexandr Antonenko and Yusaku Sako.


Bugs: AMBARI-10973
    https://issues.apache.org/jira/browse/AMBARI-10973


Repository: ambari


Description
-------

In the *Enable Kerberos Wizard*'s *Configure Kerberos* step when there are configurations that require attention the 'Attention: Some configurations need your attention before you can proceed.
+Show me properties with issues+' alert shows up.

When users click +Show me properties with issues+, and resolve their problems the alert disappears.  The issue is that there is no way to see all of the non-required properties without purposefully messing up one of the required ones so the alert comes back with the "+Show all properties+" link in it.

What should happen is as follows:
1. If there are properties that require attention, a yellow attention div is presented with "Attention: Some configurations need your attention before you can proceed.
+Show me properties with issues+"
2. The user clicks on that link and start addressing the required configurations.
3. When all of the configurations have been filled out that div is replaced with a green div with "All configurations have been addressed. +Show all properties+"


Diffs
-----

  ambari-web/app/controllers/wizard/step7_controller.js e019e1d 
  ambari-web/app/messages.js 5d85b19 
  ambari-web/app/templates/common/configs/services_config.hbs 328a954 
  ambari-web/test/controllers/wizard/step7_test.js 347a859 

Diff: https://reviews.apache.org/r/33907/diff/


Testing
-------

Manually tested.


Thanks,

Robert Levas


--===============7085508648539760956==--