Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9D0CD104FD for ; Tue, 5 May 2015 21:36:47 +0000 (UTC) Received: (qmail 47246 invoked by uid 500); 5 May 2015 21:36:47 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 47206 invoked by uid 500); 5 May 2015 21:36:47 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 47190 invoked by uid 99); 5 May 2015 21:36:47 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 May 2015 21:36:47 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 684C31DBE80; Tue, 5 May 2015 21:36:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6224505055441508508==" MIME-Version: 1.0 Subject: Re: Review Request 33863: change confirmation message for Delete widget confirmation popup From: "Xi Wang" To: "Xi Wang" , "Srimanth Gunturi" , "Yusaku Sako" Cc: "Ambari" , "Jaimin Jetly" Date: Tue, 05 May 2015 21:36:46 -0000 Message-ID: <20150505213646.8788.44505@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Xi Wang" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/33863/ X-Sender: "Xi Wang" References: <20150505210632.20177.54304@reviews.apache.org> In-Reply-To: <20150505210632.20177.54304@reviews.apache.org> Reply-To: "Xi Wang" X-ReviewRequest-Repository: ambari --===============6224505055441508508== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33863/#review82583 ----------------------------------------------------------- Ship it! Ship It! - Xi Wang On May 5, 2015, 2:06 p.m., Jaimin Jetly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33863/ > ----------------------------------------------------------- > > (Updated May 5, 2015, 2:06 p.m.) > > > Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-10942 > https://issues.apache.org/jira/browse/AMBARI-10942 > > > Repository: ambari > > > Description > ------- > > 1. Show different messages for shared and unshared widgets > 2. Read only user should not be shown the checkbox to filter unshared widgets in the footer of the widget browser > > > Diffs > ----- > > ambari-web/app/controllers/main/service/info/summary.js 58c0605 > ambari-web/app/messages.js 5998098 > ambari-web/app/templates/common/modal_popups/confirmation_feedback.hbs bda28b8 > ambari-web/app/templates/common/modal_popups/widget_browser_footer.hbs PRE-CREATION > > Diff: https://reviews.apache.org/r/33863/diff/ > > > Testing > ------- > > tested the patch on a cluster. > All existing unit tests passess successfully with the patch > > > Thanks, > > Jaimin Jetly > > --===============6224505055441508508==--